Repository navigation
Conversation
The S3 client is configured with request_checksum_calculation and response_checksum_validation, which botocore only accepts from 1.36.0. With an older boto3 installed, every obj command crashed with "TypeError: Got unexpected keyword argument 'request_checksum_calculation'". Check the botocore version when the plugin is invoked, next to the existing check for a missing boto3, and exit with a message that names the installed version and how to upgrade it. Fixes linode#769
lyelgate
requested review from
psnoch-akamai and
zliang-akamai
and removed request for
a team
November 1, 2026 11:35
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
What does this PR do and why is this change necessary?
Fixes #769.
The S3 client is configured with
request_checksum_calculationandresponse_checksum_validation, which botocore only accepts from 1.36.0. With an older boto3 installed, everylinode-cli objcommand crashed withTypeError: Got unexpected keyword argument 'request_checksum_calculation', which doesn't tell the user what to do. As noted on the issue, the fix is to upgrade boto3.This PR checks the botocore version when the plugin is invoked, next to the existing check for a missing boto3, and exits with the same exit code and a message naming the installed version and how to upgrade:
The check is on botocore because that is where
Configrejects the options; boto3 releases use the matching botocore version. The minimum is aMIN_BOTOCORE_VERSIONconstant inobj/config.py, matching theboto3>=1.36.0already declared for theobjextra inpyproject.toml. It usespackaging, which is already a dependency.✔️ How to Test
What are the steps to reproduce the issue or verify the changes?
How do I run the relevant unit/integration tests?
The new tests accept 1.36.0 and a newer version, reject 1.35.99 with the upgrade message, and check that
linode-cli obj lsexits before running the command when botocore is outdated. That last test fails without this change.black,isort,autoflakeandpylintpass, and so doesmake test-unit.