Repository navigation
TPT-4760: Support VPC subnet IDs for NodeBalancer nodes - #898
Open
zliang-akamai wants to merge 1 commit into
Open
zliang-akamai wants to merge 1 commit into
zliang-akamai wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
zliang-akamai
requested review from
psnoch-akamai and
yec-akamai
and
a balanced review from Copilot
and removed request for
a team
October 30, 2026 22:00
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the addition of subnet_id support to NodeBalancer nodes.
No open issues 🎉
What changed in this PR
Adds subnet_id support to backend nodes in linode.cloud.nodebalancer and linode.cloud.nodebalancer_node, enabling creation of VPC-backed nodes.
Changes:
- Exposes the optional integer parameter in both module specifications and documents its requirement for VPC nodes.
- Adds unit coverage for argument validation and forwarding with and without a subnet ID.
- Adds integration coverage for nested and standalone VPC nodes, subnet association on
v4beta, idempotency, and resource cleanup.
| File | Description |
|---|---|
tests/unit/modules/test_nodebalancer.py |
Tests optional subnet validation and forwarding for nested nodes. |
tests/unit/modules/test_nodebalancer_node.py |
Tests optional subnet validation and forwarding for standalone nodes. |
tests/integration/targets/nodebalancer_vpc/tasks/main.yaml |
Exercises VPC node creation, association, idempotency, and cleanup. |
plugins/modules/nodebalancer.py |
Adds subnet_id to nested node options. |
plugins/modules/nodebalancer_node.py |
Adds subnet_id to standalone node options. |
docs/modules/nodebalancer.md |
Documents the nested node subnet option. |
docs/modules/nodebalancer_node.md |
Documents the standalone node subnet option. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Expose
subnet_idfor backend nodes configured throughlinode.cloud.nodebalancerandlinode.cloud.nodebalancer_node, enabling VPC-backed nodes to be created. Update the module documentation and add unit and integration coverage for creation, subnet association, and idempotency.✔️ How to Test
Unit tests
PYTHONPATH="$(cd ../../.. && pwd)" pytest -q tests/unit/modules/test_nodebalancer.py tests/unit/modules/test_nodebalancer_node.pyIntegration test