Repository navigation
TPT-3596: Project CloudPulse Metrics Integration for Core Compute - #897
Open
yec-akamai wants to merge 3 commits into
Open
yec-akamai wants to merge 3 commits into
yec-akamai wants to merge 3 commits into
Conversation
* init * update test * fix update * update list system alerts * address comments; update docs * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * address comments * improve test --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
# Conflicts: # requirements.txt
yec-akamai
requested review from
jriddle-linode and
psnoch-akamai
and
a balanced review from Copilot
and removed request for
a team
October 30, 2026 16:19
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The integration test exposes an instance with a hard-coded root password and no firewall, while alert updates can silently drop requested lists.
6 open issues
What changed in this PR
This PR extends the linode.cloud instance module with CloudPulse alert configuration for core compute, alongside legacy alert threshold updates.
Changes:
- Adds system and user alert options, with validation restricting legacy thresholds to updates.
- Adds integration tests for system alert creation, disabling alerts, and legacy threshold updates.
- Documents the new options and raises the minimum
linode_api4version to5.49.0.
| File | Description |
|---|---|
tests/integration/targets/instance_basic/tasks/main.yaml |
Removes a trailing blank line; no behavioral change. |
tests/integration/targets/instance_alerts/tasks/main.yaml |
Adds alert lifecycle tests and instance cleanup. |
requirements.txt |
Raises the minimum SDK version. |
plugins/modules/instance.py |
Adds alert options, update support, and creation validation. |
docs/modules/instance.md |
Documents alert fields and beta availability restrictions. |
Review effort: Balanced
| region: "{{ aclp_region }}" | ||
| type: g6-standard-1 | ||
| image: linode/ubuntu22.04 | ||
| root_pass: My@Root_passhere |
|
|
||
| # Fields that can be updated on an existing instance | ||
| MUTABLE_FIELDS = {"group", "tags", "maintenance_policy"} | ||
| MUTABLE_FIELDS = {"group", "tags", "maintenance_policy", "alerts"} |
zliang-akamai
approved these changes
Oct 30, 2026
| "Note: v4beta only and may not currently be available to all users." | ||
| ], | ||
| ), | ||
| "user_alerts": SpecField( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Merge the cloud pulse metrics project into dev.
✔️ How to Test