Repository navigation
CNI Plugin Integration Test - #760
Merged
Merged
Conversation
The integration test runner script for the plugin was silently failing. Refactor the calico setup into a setup.sh script for the scenario from run-ordering.sh. Wait for the calico-kube-controllers as well as the node daemonset in the correct namespace (calico-system) vs (kube-system).
raykroeker
marked this pull request as ready for review
June 8, 2026 21:30
alpeb
approved these changes
Jun 9, 2026
alpeb
left a comment
alpeb
left a comment
Member
There was a problem hiding this comment.
Looks great to me! Just one small observation below.
Comment on lines
+10
to
+15
| # TEST_CTX must be set in the environment prior to running this script | ||
| kubectl config use-context "${TEST_CTX}" | ||
|
|
||
| # Run kubectl | ||
| function k() { | ||
| if [ -n "${TEST_CTX:-}" ]; then | ||
| kubectl --context="$TEST_CTX" "$@" | ||
| else | ||
| kubectl "$@" | ||
| fi | ||
| kubectl "$@" |
Member
There was a problem hiding this comment.
Why this change? Previously a missing TEST_CTX was handled gracefully; with this change kubectl config use-context will fail.
Member
Author
There was a problem hiding this comment.
Looking at all of the places it was called (w/in the justfile) TEST_CTX was always provided. So the branching was not required.
It make the script simpler to understand that TEST_CTX was not optional, and we set it for the entire run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integration test script for the cni plugin was incorrectly exiting with status code '0' when calling the
wait_rolloutfunction. Fixerun.shto exit when the rollout status fails.Refactor the calico setup into a setup.sh script for the integration test scenario from run-ordering.sh.
Wait for the calico-kube-controllers as well as the node daemonset in the correct namespace (calico-system) vs (kube-system).