Repository navigation
fix(cni-plugin): remove square brackets from host which may not be ipv6 in kubeconfig - #589
Merged
Merged
Conversation
Signed-off-by: Alex Leong <alex@buoyant.io>
alpeb
approved these changes
Oct 28, 2025
|
Hi shouldnt this fix test if there is ":" in the host and keep brackets if so? cause to fix ipv4 the fix breaks ipv6 case now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the install-cni script generates a kubeconfig for the cni-plugin, it wraps the kubernetes service host in square brackets. This is not valid if the host is an ipv4 address and, as of recent versions of Go, such hosts will fail to be parsed by the
net/urlpackage. See: golang/go@d6d2f7bRemove the square brackets so that this host can be parsed properly.