Repository navigation
fix: round pre-epoch dates down to their UTC day - #313
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encoding a date from a time.Time before 1970 with a non-midnight time currently rounds toward zero. For example, 1969-12-31T12:00:00Z becomes day 0 and decodes as 1970-01-01, rather than day -1.
Round negative, non-integral day counts down while keeping the existing UTC conversion. This preserves the intended day when discarding the time component and matches the Avro date representation.
Seven cases cover negative partial days, the nanosecond before the epoch, exact midnight, and positive dates. Each checks binary encoding, textual encoding, and binary decoding to midnight. Three cases fail before the fix. All tests (
go test ./...), package static checks (go vet .), gofmt, and diff whitespace checks pass afterward.go vet ./...still reports unreachable code in the unchanged examples/soe/main.go:52.