Repository navigation
Update PackTab to 1.9.0 - #674
Merged
Merged
Conversation
|
Thank you. I'll merge & release packtab.rs. |
|
Thanks. packtab.rs 1.9.0 is released. |
taj-p
marked this pull request as ready for review
July 3, 2026 22:58
taj-p
enabled auto-merge
July 3, 2026 22:58
tomcur
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Upgrade to the new PackTab 1.9.0.
I previously tested the PR (behdad/packtab.rs#2) in 22bbd1d prior to updating this PR to use the new 1.9.0 version. That investigation is below:
Tested against cases our existing
--compression=5, but also--compression=0and--compression=10. Our regressions tests pass for all cases - so, it's correct as far as Parley is concerned.At compression=10, I noticed a 7 byte reduction relative to current PackTab - I believe that's expected because the proposed PR drops dead padding bytes