feat(LINCHPIN-5639): Build the admin screen on the shared Linchpin UI library - #20
Merged
Merged
Conversation
… library The brand bar, page header, two column body, help column, footer and danger zone now come from @linchpinagency/ui. That removes four hand rolled components, the two Linchpin logo files and 190 lines of stylesheet, and the sidebar becomes three of the library's cards. Sections are links rather than TabPanel state, so ?tab= is a real address that survives a save, and a fifth section renders the standard About Linchpin page. Two changes to the Pages section while it was open: the page picker puts search and create on one line, and the front end accounts switch appears beside the three pages it governs, with their inputs hidden until it is on. Requires @linchpinagency/ui 0.2.3, which is not published yet, so npm ci will fail until it is.
…ibrary The library released as 0.3.0 rather than the 0.2.3 this branch was written against: release-please treats a feature on a pre-1.0 package as a minor bump, and a caret range on a 0.x version pins the minor, so ^0.2.3 would not have matched it. Verified against the published package rather than a local pack: lint, build and both test suites pass, and the chrome lands in build/admin.css with no webpack configuration of its own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Psst is the first real consumer of
@linchpinagency/ui. Task: Standard admin component library: linchpin/ui.@linchpinagency/ui@0.3.0is published and this branch is on it. (The library released as 0.3.0, not the 0.2.3 this was first written against — release-please treats a feature on a pre-1.0 package as a minor bump.)What changed
The brand bar, page header, two-column body, help column, footer and danger zone all come from the library now. Four hand-rolled components and both Linchpin logo files are gone, the sidebar is three of the library's cards, and
admin.scssdrops from 413 lines to 220.components/topbar.js+ 2 SVGs<LinchpinAdminTopBar>components/masthead.js+TabPanel<LinchpinAdminPage>(core'sPage) +sectionNavigation()components/footer.js<LinchpinAdminFooter>components/notices.js<LinchpinNotices>Section/PageCardwrappers<SettingsCard><DangerZone>BRANDand UTM linksdefineBrand()+linchpinLinks()Sections are links rather than
TabPanelstate, so?tab=pagesis a real address that survives a save — the URLs the e2e suite already navigates to are unchanged. A fifth section renders the standard About Linchpin page.Two changes to the Pages section
Verified
Every section in a browser against the Studio site: settings, pages, secrets, health, about. The accounts switch round-trips — saving it on created the three account pages and all five went to Ready — and I toggled it back off afterwards. Snackbar centres at 720/720 with only the library's class on it. No console errors.
lint:js,lint:css, build, 15 crypto tests and 106 PHP tests pass. The Playwright e2e suite was not run locally (needs the Playground server); its selectors are intact.