feat(NO-TASK): Bundle parallel-lint so the standard is one dependency - #48
Merged
Merged
Conversation
Every repository that requires this package also requires parallel-lint separately - 12 of 12, no exceptions - and each spells the constraint its own way: ^1.4, ^1.4.0 and ^v1.4.0 are all in use. One require here replaces all of them, and the 23 repositories about to adopt the standard get one line instead of two. php-console-highlighter comes with it, matching 11 of the 12. Slight impurity acknowledged: this package is type phpcodesniffer-standard and parallel-lint is not a sniff. It is inert either way - the installer plugin only scans for rulesets - and the package already carries a non-sniff require-dev. Worth it over a second package nobody would remember to add. Verified against a path-repo consumer: one require yields parallel-lint, phpcs and phpcbf, and every standard still registers. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
php-parallel-lint/php-parallel-lintandphp-console-highlightertorequire, so taking the standard means taking the toolchain.The co-occurrence is absolute
linchpin/coding-standardsThere is no case in the org where someone wants the standard without it. And
each spells the constraint differently —
^1.4,^1.4.0,^v1.4.0(strayv)— so one require here removes a whole class of drift. 11 of the 12 also carry
php-console-highlighter, so that comes too.Timely: 23 repos are about to adopt the standard as part of moving off the
phpcs/phpcbf/phplinttrio. They get one line instead of two.The argument against, stated plainly
This package is
type: phpcodesniffer-standardand parallel-lint isn't a sniff.Practically it's inert — the installer plugin only scans for rulesets, and the
package already carries a non-sniff
require-dev(phpunit/phpunit). I'd takethe small impurity over a second package nobody remembers to add.
If phpstan and php-cs-fixer get standardised too, the cleaner long-term shape is
a
linchpin/php-devmetapackage requiring this one plus the tools. That layerson top without undoing this.
Verified
Against a path-repo consumer requiring only this package:
Every standard still registers.
composer validateclean.For existing consumers
No change required — an explicit
requirealongside is harmless. They can droptheir own parallel-lint line whenever convenient.
feat, so release-please cuts v1.2.0.