-
Notifications
You must be signed in to change notification settings - Fork 5
Add Global Accounts launch homepage updates #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3250,7 +3250,7 @@ html.dark .hero-tagline { | |
| .hero-banner-bg { | ||
| position: absolute; | ||
| inset: 0; | ||
| background-image: url('/images/home/sand.png'); | ||
| background-image: url('/images/home/banner-bg.webp'); | ||
| background-size: cover; | ||
| background-position: center center; | ||
| background-repeat: no-repeat; | ||
|
|
@@ -3328,15 +3328,6 @@ html.dark .hero-tagline { | |
| } | ||
| } | ||
|
|
||
| html.dark .hero-banner-button { | ||
| background: var(--ls-gray-950); | ||
| color: var(--ls-gray-050); | ||
| } | ||
|
|
||
| html.dark .hero-banner-button:hover { | ||
| background: var(--ls-gray-900); | ||
| } | ||
|
|
||
| /* =========================================== | ||
| Info Cards (Understand Grid & Start Building) | ||
| =========================================== */ | ||
|
Comment on lines
3328
to
3333
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The Prompt To Fix With AIThis is a comment left during a code review.
Path: mintlify/style.css
Line: 3328-3333
Comment:
**Dark mode button styles removed without replacement**
The `html.dark .hero-banner-button` and its `:hover` state are deleted. Previously in dark mode, the button had a distinct dark background (`var(--ls-gray-950)`) and light text (`var(--ls-gray-050)`). Without these overrides, the button will fall back to its light-mode appearance in dark mode — which may produce poor contrast or look unintentional depending on the button's base CSS. If this deletion is intentional (e.g., the new design is the same across themes), a brief comment confirming that would help reviewers.
How can I resolve this? If you propose a fix, please make it concise.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no this is good because the background is dark on both light and dark mode so the button should be light. |
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
transfers > payments?