Skip to content

bolt12: export DecodeOffer #11199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
usefahmed07 wants to merge 2 commits into from
Closed

bolt12: export DecodeOffer #11199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f05abe
bolt12: export DecodeOffer
usefahmed07 Sep 17, 2026
74bb3b2
bolt12: fix remaining decodeOffer call sites broken by DecodeOffer re…
usefahmed07 Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bolt12/decode_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func TestDecodeRejectsNonMinimalFeatures(t *testing.T) {
name: "offer_features",
typ: 12,
decode: func(b []byte) error {
_, err := decodeOffer(b)
_, err := DecodeOffer(b)
return err
},
},
Expand Down
2 changes: 1 addition & 1 deletion bolt12/invoice_request_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ func TestNewInvoiceRequestFromOfferMirrorsUnknownFields(t *testing.T) {
// sorted.
spliced := append(append([]byte{}, encoded...), extra.Bytes()...)

decodedOffer, err := decodeOffer(spliced)
decodedOffer, err := DecodeOffer(spliced)
require.NoError(t, err)

ir, err := NewInvoiceRequestFromOffer(
Expand Down
4 changes: 2 additions & 2 deletions bolt12/offer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,12 +109,12 @@ func (o *Offer) Encode() ([]byte, error) {
return buf.Bytes(), nil
}

// decodeOffer parses a TLV byte stream into an Offer. Decoding is permissive —
// DecodeOffer parses a TLV byte stream into an Offer. Decoding is permissive —
// the spec writer requirements are not enforced here, so callers that need a
// valid offer must run ValidateOfferRead. Unknown TLVs are preserved on the
// returned offer so a later Encode can re-emit signed-range extras and keep
// offer_id stable.
func decodeOffer(data []byte) (*Offer, error) {
func DecodeOffer(data []byte) (*Offer, error) {
var o Offer

// Prepare zero-valued records for all optional fields so the TLV
Expand Down
6 changes: 3 additions & 3 deletions bolt12/offer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ func TestOfferRoundTrip(t *testing.T) {
require.NoError(t, err)
require.NotEmpty(t, encoded)

decoded, err := decodeOffer(encoded)
decoded, err := DecodeOffer(encoded)
require.NoError(t, err)

require.Equal(t, TUint64(1500), decoded.OfferAmount.UnwrapOrFailV(t))
Expand Down Expand Up @@ -68,7 +68,7 @@ func TestDecodeOversizedRecord(t *testing.T) {
require.NoError(t, tlv.WriteVarInt(&w, oversize, &buf))
w.Write(make([]byte, oversize))

_, err := decodeOffer(w.Bytes())
_, err := DecodeOffer(w.Bytes())
require.ErrorIs(
t, err, tlv.ErrRecordTooLarge,
"expected an oversize-record rejection, got %v", err,
Expand All @@ -87,7 +87,7 @@ func TestDecodeOfferString(t *testing.T) {
_, tlvBytes, err := Decode(offerStr)
require.NoError(t, err)

offer, err := decodeOffer(tlvBytes)
offer, err := DecodeOffer(tlvBytes)
require.NoError(t, err)

// Verify issuer ID is present and correctly typed.
Expand Down
4 changes: 2 additions & 2 deletions bolt12/validate_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3024,7 +3024,7 @@ func TestValidateOfferReadVectors(t *testing.T) {
return
}

offer, decodeErr := decodeOffer(tlvBytes)
offer, decodeErr := DecodeOffer(tlvBytes)
if decodeErr != nil {
if tc.Valid {
require.NoError(
Expand Down Expand Up @@ -3132,7 +3132,7 @@ func TestOfferVectorsLayerCensus(t *testing.T) {
continue
}

offer, decodeErr := decodeOffer(tlvBytes)
offer, decodeErr := DecodeOffer(tlvBytes)
if decodeErr != nil {
tlvRejections++
continue
Expand Down
Loading