Repository navigation
[bug]: missing description to wtclient command "session" and "terminate" command option #9583
Closed as not planned
Description
Background
After navigating around the lncli wtclient subcommands, I noticed there are missing descriptions and "how to use" for session and terminate command options
Your environment
- version of
lnd: 0.18.5 - which operating system: Ubuntu Server Jammy LTS
- version of
btcd,bitcoind, or other backend: bitcoind
Steps to reproduce
Navigate around the lncli wtclient subcommands
Expected behaviour
Detailed description of "how to use" for session and terminate subcommand option
Actual behaviour
Missing information
Screenshots
Possible code lines to be addressed
https://github.com/lightningnetwork/lnd/blob/master/cmd/commands/wtclient.go#L378-L420
Edit:
PR related: #9588
Activity
Update wtclient.go
Update wtclient.go
MKVEERENDRA commentedon Mar 7, 2025
#9588 Pls check this
twofaktor commentedon Mar 7, 2025
Checked, see comment
etimofeeva commentedon Mar 9, 2025
is this still in the need of a triage?
shivansh-bhatnagar18 commentedon Mar 19, 2025
@twofaktor The
sessionCommandscurrently contains only the terminate command for the watchtower operations which itself has a commandterminate. So added the description accordinglyAbhinavAnand241201 commentedon Apr 15, 2025
can i create a PR for this ??...
twofaktor commentedon Apr 15, 2025
There's already a PR #9588 underway, although it's a bit abandoned. If you want to take it up again...go ahead
Update wtclient.go
AbhinavAnand241201 commentedon Apr 15, 2025
@twofaktor should i submit a PR or leave it cuz i can see the guy is active now and he has made a commit ....
saubyk commentedon Apr 15, 2025
Hi @AbhinavAnand241201 you can try to review the pr instead
AbhinavAnand241201 commentedon Apr 15, 2025
yess exactly ...i was going to do this ..but was waiting for @twofaktor 's reply...
since this guy @MKVEERENDRA
was inactive for quite some time ...and he might vanish again ....so i was a bit unsure...but for now i'll review the PR instead ..
MKVEERENDRA commentedon Apr 16, 2025
Thanks for the heads-up, @AbhinavAnand241201 and @saubyk.
Totally fair point — I had been a bit inactive earlier, but I’m back on this now and will be maintaining the PR actively. That said, I really appreciate you checking in and offering to help. If you spot anything in the PR that can be improved, I’d love your feedback or suggestions in the review!
Let’s collaborate and get it merged properly 💪
Update wtclient.go
Update wtclient CLI commands with refined descriptions and formatting…