Repository navigation
Conversation
Require the option_scid_alias channel type for new unannounced channels when both peers advertise support. This lets peers rely on alias-only forwarding and reduces exposure to probes using real SCIDs derived from P2WSH outputs observed on chain. Mark support as ASSUMED while retaining feature advertisements and conditioning the channel type requirement on them. This leaves a compatibility window for peers that do not advertise support. Co-Authored-By: HAL 9000
Contributor
Author
|
Oh, it seems while LND generally supported @Roasbeef I found some old discussions that indicate you had planned to switch the default to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
option_scid_aliaschannel type was introduced in #910.I want to propose to make
option_scid_aliasASSUMED in general and require implementations to require the channel type (i.e., disallow forwarding over real SCIDs of unannounced channels) when both parties negotiate the feature.