BOLT 4: clarify final onion payload must always contain total_msat - #1355
Merged
Roasbeef merged 1 commit intoSep 21, 2026
Merged
Conversation
Now that `option_payment_secret` is assumed [0], the `total_msat` field must always be present for final onions. [0]: lightning@872c6ec
15 of 22 tasks
t-bast
approved these changes
Aug 28, 2026
t-bast
left a comment
t-bast
left a comment
Collaborator
There was a problem hiding this comment.
ACK, agreed that we can get rid of this legacy case now.
TheBlueMatt
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that
option_payment_secretis assumed, thetotal_msatfield must always be present for final onions.Either the
payment_dataTLV or thetotal_amount_msatTLV must be present, which impliestotal_msatbeing present.