Skip to content

feat: az provider session image support to proc images - #360

Merged
rubengomex merged 5 commits into
mainfrom
LP-112087
Jun 23, 2026
Merged

feat: az provider session image support to proc images#360
rubengomex merged 5 commits into
mainfrom
LP-112087

Conversation

@rubengomex

@rubengomex rubengomex commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Copilot AI review requested due to automatic review settings June 18, 2026 14:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Ready to approve

The functional changes are straightforward and test-covered, with only minor test-file cleanup nits (unused variables) remaining.

Note: this review does not count toward required approvals for merging.

Pull request overview

Adds support in the procurement images CLI for selecting the Azure provider and the VSCodeInteractiveSessions image type, plus extends the procurement image tests to cover these new inputs.

Changes:

  • Extend procurement images set/reset CLI commands to accept provider azure and image type VSCodeInteractiveSessions.
  • Update procurement Images method docstrings to document Azure and VSCode support.
  • Add/extend pytest coverage for Azure provider cases, multiple Azure regions, and VSCode session image type.
File summaries
File Description
tests/test_procurement/test_set_procurement_organisation_image.py Expands set-image tests to cover Azure provider, Azure regions, and VSCodeInteractiveSessions.
tests/test_procurement/test_reset_procurement_organisation_image.py Expands reset-image tests to cover Azure provider, Azure regions, and VSCodeInteractiveSessions.
cloudos_cli/procurement/images.py Updates method docstrings to include Azure provider and VSCodeInteractiveSessions image type.
cloudos_cli/procurement/cli.py Updates CLI option choices to allow azure provider and VSCodeInteractiveSessions image type for set/reset.

Copilot's findings

  • Files reviewed: 4/4 changed files
  • Comments generated: 2

Note

Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/test_procurement/test_set_procurement_organisation_image.py
Comment thread tests/test_procurement/test_reset_procurement_organisation_image.py
@rubengomex
rubengomex marked this pull request as draft June 18, 2026 16:05
@rubengomex rubengomex changed the title feat: add azure provider type and VSCode session image type feat: az provider and vscode session image types to proc images Jun 19, 2026
@rubengomex
rubengomex marked this pull request as ready for review June 22, 2026 16:25
@rubengomex rubengomex changed the title feat: az provider and vscode session image types to proc images feat: az provider session image support to proc images Jun 23, 2026

@l-mansouri l-mansouri left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rubengomex we need a changelog entry and the version bump for sure. The rest of the PR seems to be 1 new test and a bunch of "aesthetic" code clean up, is that it?

@dapineyro dapineyro left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dapineyro
dapineyro self-requested a review June 23, 2026 09:56

@dapineyro dapineyro left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! as @l-mansouri says, the only lacking thing is an entry in changelog.md

@l-mansouri
l-mansouri dismissed dapineyro’s stale review June 23, 2026 10:11

Already approved

@dapineyro dapineyro left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rubengomex
rubengomex merged commit 6655c5a into main Jun 23, 2026
4 checks passed
@rubengomex
rubengomex deleted the LP-112087 branch June 23, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants