fix(deps): override fast-uri to ^3.1.7 and qs to ^6.16.0 to resolve CVEs (#3313) - #3314
fix(deps): override fast-uri to ^3.1.7 and qs to ^6.16.0 to resolve CVEs (#3313)#3314agentHits wants to merge 1 commit into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
⏳ DRAFT
What to do
Review readiness checklist
✅ 4/4 boxes ticked. This pull request is being kept as a draft automatically. Once every issue above is resolved, it will be marked ready for review again. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe package overrides update ChangesDependency override update
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized dependency update removes reported vulnerabilities without changing application behavior; the supplied audit, typecheck, and hygiene checks pass, and no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
Full details: Linked Issues checkExplanation The package.json overrides set fast-uri to ^3.1.7 and qs to ^6.16.0, which matches issue Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
리뷰 · 우선순위 61 / 80설명 이 PR은 왜 지금 변경 폭은 라인 package.json overrides.fast-uri - 라인 package.json overrides.qs - 신규 경로 bun.lock packages.fast-uri / packages.qs - 오버라이드와 락 엔트리가 같이 올라간 점은 좋다. 오버라이드만 올리고 락을 안 맞추면 CI/로컬이 어긋난다. 다만 경로 intake: hygiene-blocked / unsponsored_surface - 작성자가 고칠 코드 버그가 아니라 정책 게이트다. 의존성 표면이라 메인테이너가 advisory 범위와 락 해석을 본 뒤 경로 #3313 본문의 구버전 숫자 - 이슈는 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
|
Thanks for the thorough review @lidge-jun! To clarify the points mentioned:
Ready for |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary
Overrides transitive dependencies
fast-urito^3.1.7andqsto^6.16.0inpackage.jsonto eliminate 6 vulnerabilities detected bybun audit(4 High infast-uri, 2 Moderate inqs).Closes #3313
fast-uri: fixes GHSA-5jgf-p345-68v8, GHSA-f65p-4m7j-42xc, GHSA-fph4-wmhf-6fwf, and GHSA-jqff-g426-hqxp.qs: fixes GHSA-x5fp-wj9c-mxmx and GHSA-4mjr-xmp4-gh2g.Verification
bun audit— 0 vulnerabilities reported (No vulnerabilities found).bun run typecheck— passed (bun x tsc --noEmit).bun test tests/repo-hygiene.test.ts— passed (12 passed, 0 failed).Checklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
All CI tests are green on my local testing.
I pushed my PR to the latest dev commit.
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.
Summary by CodeRabbit