fix(export): preserve Hermes vision capabilities (carry of #3151) - #3178
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
✅ Deterministic PR hygiene checks passed. |
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Maintainer rebase carry of #3151 by @Ingwannu — the original commit cherry-picked onto current
devwith author credit preserved. No content change.Replaces the Hermes string-only model array with the metadata map Hermes uses for custom-provider capability lookup, so
supports_visionis emitted from exported catalog modalities:truefor rows whose modalities include image,falsefor an explicit non-empty modality list without image, and no flag at all when modalities are unknown. Stable selector ordering, existing admission references, YAML round-tripping, CLI and management parity, and the no-guessed-video boundary are preserved.Why a carry branch. #3151's head sat 105 commits behind
dev, well past the repository's 10-commit freshness boundary, so its CI run no longer described what would land. A maintainer cannot push to a contributor branch, so the commit is re-applied here. The rebase was clean — one auto-merge instructure/09_client-integrations.md, no conflicts.On the original's red CI. #3151's
cicheck was only a rollup reportingplatform-macos=failure, and that macOS job's single failure wasserver local API auth > websocket passthrough refreshes pool auth for each response.create turn(tests/server-auth.test.ts) — a known macOS flake, in websocket auth, nowhere near this diff's Hermes export surface. The author's claim that the failure was pre-existing checked out.Closes #3146. Supersedes #3151.
Verification
Exact head
298bb8329:bun test ./tests/client-export-modality-enum.test.ts ./tests/cli-export-command.test.ts ./tests/client-config-export-new-clients.test.ts ./tests/client-config-new-clients.test.ts ./tests/management-client-config-route.test.ts— 100 pass, 0 fail, 512 expect() calls.0d6424f80;git show --statconfirms the same 7 files, +97/-13 as the original.Full-suite and typecheck coverage is left to CI on this exact head.
Checklist
dev