Skip to content

fix(export): preserve Hermes vision capabilities (carry of #3151) - #3178

Merged
lidge-jun merged 1 commit into
devfrom
codex/3151-hermes-vision-carry
Sep 1, 2026
Merged

fix(export): preserve Hermes vision capabilities (carry of #3151)#3178
lidge-jun merged 1 commit into
devfrom
codex/3151-hermes-vision-carry

Conversation

@lidge-jun

Copy link
Copy Markdown
Owner

Summary

Maintainer rebase carry of #3151 by @Ingwannu — the original commit cherry-picked onto current dev with author credit preserved. No content change.

Replaces the Hermes string-only model array with the metadata map Hermes uses for custom-provider capability lookup, so supports_vision is emitted from exported catalog modalities: true for rows whose modalities include image, false for an explicit non-empty modality list without image, and no flag at all when modalities are unknown. Stable selector ordering, existing admission references, YAML round-tripping, CLI and management parity, and the no-guessed-video boundary are preserved.

Why a carry branch. #3151's head sat 105 commits behind dev, well past the repository's 10-commit freshness boundary, so its CI run no longer described what would land. A maintainer cannot push to a contributor branch, so the commit is re-applied here. The rebase was clean — one auto-merge in structure/09_client-integrations.md, no conflicts.

On the original's red CI. #3151's ci check was only a rollup reporting platform-macos=failure, and that macOS job's single failure was server local API auth > websocket passthrough refreshes pool auth for each response.create turn (tests/server-auth.test.ts) — a known macOS flake, in websocket auth, nowhere near this diff's Hermes export surface. The author's claim that the failure was pre-existing checked out.

Closes #3146. Supersedes #3151.

Verification

Exact head 298bb8329:

  • bun test ./tests/client-export-modality-enum.test.ts ./tests/cli-export-command.test.ts ./tests/client-config-export-new-clients.test.ts ./tests/client-config-new-clients.test.ts ./tests/management-client-config-route.test.ts100 pass, 0 fail, 512 expect() calls.
  • Cherry-pick applied cleanly onto 0d6424f80; git show --stat confirms the same 7 files, +97/-13 as the original.

Full-suite and typecheck coverage is left to CI on this exact head.

Checklist

  • Targets dev
  • Author credit preserved via cherry-pick; this is a rebase carry, not a rewrite
  • No credential, auth, workflow, or release-automation surface touched — export emits environment references only
  • No new dependency; no config or schema change

@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner September 1, 2026 17:11
@lidge-jun
lidge-jun merged commit 51c4917 into dev Sep 1, 2026
6 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-01T17:15:17.921774Z 298bb83 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@lidge-jun
lidge-jun deleted the codex/3151-hermes-vision-carry branch September 1, 2026 17:11
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Deterministic PR hygiene checks passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants