Skip to content

test(auth): seed the pool quota after the clock is pinned #3147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidge-jun merged 2 commits into from
Sep 1, 2026
Merged

test(auth): seed the pool quota after the clock is pinned #3147

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecf51c6
test(auth): seed the pool quota and credential after the clock is pinned
Sep 1, 2026
0cf5ef7
test(auth): restore the affinity test's quota seed after the pin
Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 23 additions & 14 deletions tests/server-auth.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2125,17 +2125,17 @@ describe("server local API auth", () => {
expiresAt: now + CODEX_THREAD_AFFINITY_IDLE_TTL_MS + 10 * 60_000,
chatgptAccountId: "acct-pool-a",
});
updateAccountQuota("pool-a", 10, 5);

const originalNow = Date.now;

@chatgpt-codex-connector chatgpt-codex-connector Bot Sep 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore the quota seed in the affinity test

The removed call belongs to the preceding expired thread affinity test, not the websocket-refresh test being fixed. Without a cached quota, startServer treats pool-a as stale and its background startup prime issues an additional /backend-api/wham/usage request through redirectCanonicalCodexTo, incrementing upstreamRequests beyond the three requests asserted at lines 2151 and 2199 whenever the prime completes in time. Restore this seed after that test pins Date.now, and instead remove the still-present pre-pin seed from the following websocket-refresh test.

Useful? React with 👍 / 👎.

// Pin the clock BEFORE startServer, not after. `startServer` returns synchronously but
// arms an async pool-quota prime (src/server/index.ts:2054-2064) that outlives its
// return, and that prime decides staleness with `Date.now() - quota.updatedAt >=
// POOL_CACHE_TTL` (src/codex/auth-api.ts:1334-1337). `updateAccountQuota` above stamped
// `updatedAt` with the REAL clock, so a prime that lands after a 2027 fake clock is
// installed sees months of cache age, fetches, and rotates the credential out from under
// the assertions. Installing the clock first closes the window entirely.
// POOL_CACHE_TTL` (src/codex/auth-api.ts:1334-1337), where a MISSING entry is stale too.
// Seeding the quota after the pin is what actually keeps the prime quiet: a seed written
// before the pin stamps `updatedAt` with the real clock, which reads as months of cache
// age against this 2027 `now` and sends the prime off to fetch and rotate the credential
// out from under the assertions.
Date.now = () => now;
updateAccountQuota("pool-a", 10, 5);
const server = startServer(0);
try {
for (const threadId of ["expired-http", "expired-compact", "expired-ws"]) {
Expand Down Expand Up @@ -2240,14 +2240,6 @@ describe("server local API auth", () => {
codexAccountNamespaces: { "ws-refresh": "pool-a" },
activeCodexAccountId: "pool-a",
} as OcxConfig);
saveCodexAccountCredential("pool-a", {
accessToken: "old-access-token",
refreshToken: "old-refresh-token",
expiresAt: now + 120_000,
chatgptAccountId: "acct-pool-a",
});
updateAccountQuota("pool-a", 10, 5);

const originalNow = Date.now;
const originalFetch = globalThis.fetch;
// Both the clock and the fetch stub go up before `startServer`. The async pool-quota
Expand All @@ -2258,6 +2250,23 @@ describe("server local API auth", () => {
// credential before the first turn was served — so `seenAuth[0]` was already the new
// token. The failure diff was always the first element, never the second.
Date.now = () => now;
// Seed the credential and quota AFTER the clock is pinned.
//
// Both writes stamp real time when they run before the pin: `updateAccountQuota` sets
// `updatedAt: Date.now()`, and `saveCodexAccountCredential` sets `replacedAt`. The
// startup pool-quota prime then compares those stamps
// against this 2027 `now` and judges stale — so it refreshes the credential before the
// first turn is served and `seenAuth[0]` is already the new token. Pinning the clock
// and the fetch stub first (#3139) closed the window for the prime's own reads, but not
// for a timestamp written before either was in place, which is why this kept flaking on
// loaded runners after that fix.
saveCodexAccountCredential("pool-a", {
accessToken: "old-access-token",
refreshToken: "old-refresh-token",
expiresAt: now + 120_000,
chatgptAccountId: "acct-pool-a",
});
updateAccountQuota("pool-a", 10, 5);
globalThis.fetch = (async (input, init) => {
const url = typeof input === "string" ? input : input instanceof URL ? input.href : input.url;
if (url === "https://auth.openai.com/oauth/token") {
Expand Down
Loading