[WRONG BRANCH] chore(release): move preview to 2.39.0-preview.20260831 - #3077
[WRONG BRANCH] chore(release): move preview to 2.39.0-preview.20260831#3077lidge-jun wants to merge 1 commit into
Conversation
The preview promotion carried 2.38.0-preview.20260831, chosen before v2.38.0 was published. Publishing the stable 2.38.0 made that prerelease BEHIND a released version, and tests/release-version-line.test.ts asserts the in-tree version is never behind one. Cross-platform CI on preview went red on exactly that assertion (macos and test 1/4), with every other check green. A prerelease outranks nothing once its own core ships. Move the preview line to the next unconsumed core, matching dev's move to 2.39.0.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
github-actions
Bot
added
the
chore
|
✅ Deterministic PR hygiene checks passed. |
github-actions
Bot
changed the title
⏳ DRAFT
What to do
Its title has been prefixed with |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe package version in ChangesPackage Version
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized version update moves the preview line to 2.39.0-preview.20260831; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
리뷰 · 우선순위 66 / 80이 PR은 제품 기능을 바꾸지 않습니다. 왜 지금 빨간가. 올리는 숫자는 지금 초안을 라인 package.json version - 2.38.0-preview.20260831 → 2.39.0-preview.20260831. 이 PR의 유일한 변경 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
|
Closing as overtaken by history rather than as wrong. This proposes moving Verified just now: The underlying problem it was opened for — the No action needed on the branch; nothing here is lost. |
…l mid-fixture (#3139) * docs(devlog): plan merge train round 3 Roadmap for landing the green PRs, retiring the superseded ones, and rebasing the rest, frozen at dev=132b557ad. Includes the round-1 audit synthesis: three blockers folded (fork PRs are carried by cherry-pick rather than force-pushed, because enforce-pr-target.yml applies the readiness checklist to authors without push permission; #3039's closure withdrawn because #3104 prints the configured budget where #3039 printed the elapsed wait; the src/service.ts overlap is 330470e, not 0ef04e6) and two rebutted with evidence. * docs(devlog): record wp1 — #3114 landed as abcda8e * docs(devlog): record the wp2 security review for #3122 * docs(devlog): record wp3 — #3134 landed, #3128 flake premise corrected * docs(devlog): record wp5 — #3077 closed, #3109/#3112 rebased * docs(devlog): locate the websocket refresh flake, and correct the #3128 premise * docs(devlog): prove the flake mechanism and correct its direction * docs(devlog): mark the superseded flake explanation in the wp5 record * test(auth): install the fake clock and fetch stub before startServer startServer returns synchronously but arms an async pool-quota prime that outlives its return (src/server/index.ts:2054-2064). That prime calls getValidCodexToken, which can rotate the very credential these assertions read, and fetches a real host unless the stub is up. Both fixtures installed Date.now and globalThis.fetch AFTER startServer, leaving a window two dynamic import() resolutions wide where the prime ran against the real clock and real fetch. On a warm local module cache it resolved before the fixture finished; on a loaded CI runner it did not, and seenAuth[0] was already the rotated token. Measured rather than assumed: OPENCODEX_DEBUG_QUOTA=1 prints refreshed=1 on every run of both the fixed and unfixed trees, so the prime always fires. The fix does not suppress it -- it makes it run inside the fixture's controlled world. The thread-affinity test at :2131 had the identical shape and is fixed too.
1 participant
Summary
Cross-platform CI went red on
previewright after the v2.38.0 promotion, onmacosandtest 1/4. One assertion, in both:Every other check on that run passed.
The cause is ordering, not a defect. The preview promotion was prepared as
2.38.0-preview.20260831while2.38.0was still unpublished, which was correct at the time. Publishing the stable2.38.0immediately afterwards consumed that core, and a prerelease of an already-released version is by definition behind it.Move the preview line to the next unconsumed core,
2.39.0-preview.20260831, matchingdev's move to2.39.0in #3076.Verification
bun test tests/release-version-line.test.ts— 3 pass / 0 fail.Note
enforce-targetfails on any PR not targetingdev; that applies here as it does to promotion PRs.Checklist
package.jsontoucheddevbump in chore(release): move dev to 2.39.0 after the v2.38.0 release #3076Summary by CodeRabbit
2.39.0-preview.20260831.