docs(devlog): record the release-readiness train and its outcome - #2974
Conversation
…ring Eight rebased PRs reached a green technical matrix. Merging them in arrival order would be unsafe: five pairs share a src/ file and three of those share src/config.ts, so a later merge would resolve conflicts blindly. The unit records a mechanically computed overlap matrix, a collision-degree ordering that lands #2854 last because it is the only PR bridging two clusters, per-merge rebase mechanics, and designs for the two PRs that cannot merge as-is: #2429 trips privacy:scan on an email literal, and #2827 ships a response header no browser can read.
Eight bug-class pull requests and fifteen issues were audited against dev@47b8d1643 in isolated worktrees. Only two of the eight merge as-is; five need a repair commit and one needs reimplementing, and of the fifteen issues only two are fixable now — the rest need a measurement nobody has taken or a design cycle. The unit records the computed file-overlap matrix (three collisions, one of them an identical commit shared by two PRs), the merge order those collisions dictate, and one decade doc per work phase. It also records the Windows mechanic that shapes the train: platform-windows only runs on workflow_dispatch, and ci.yml concurrency is keyed on github.ref, so a merge to dev cancels a dev-targeted dispatch.
A plan audit returned FAIL on two counts. The baseline Windows dispatch was scheduled against dev, and ci.yml keys its concurrency group on github.ref for workflow_dispatch as well as push, so merging #2952 cancelled all four windows shards twenty seconds later. Every Windows dispatch now targets a dedicated branch ref, and the cancelled baseline is recorded as unavailable rather than quietly replaced by the later run. The second blocker: pushing a repair commit to a contributor PR resets the enforce-target readiness checklist and returns the PR to draft, and that checklist is an author attestation a maintainer must not tick on their behalf. Four PRs are in that state. The docs now carry the maintainer-owned carry-PR path -- cherry-pick preserves author metadata -- instead of merge steps that cannot execute.
Ten pull requests landed, two issues closed, five contributor PRs closed as carried or superseded, and four Windows-only defects fixed that no push run could have seen -- platform-windows only runs on workflow_dispatch, so the CI that gates release.yml covers Linux, macOS and the gates and nothing else. None of the four Windows failures was a product defect. Four tests were asserting things that are false on a platform the project supports. The prompt-route case needed two passes and is recorded in full: the first fix used a posix filename containing a literal backslash, which is a filename character on POSIX and a separator on Windows, so the fixture parent directory never existed and the case failed earlier rather than passing. The duration falling from 243ms to 4ms is what identified it.
|
Warning Review limit reachedNext included review available in 1 minute. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (11)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
github-actions
Bot
added
the
documentation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e3c5f70fc6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # 260829 — Green-PR merge train | ||
|
|
||
| Eight rebased pull requests reached a fully green test matrix on `dev@e546c160b` and are | ||
| candidates to land. This unit records why each one is safe to merge, the order the merges | ||
| must happen in, and the two integration designs that have to be built before their PRs can |
There was a problem hiding this comment.
Move this restored unit to _fin and add its terminal disposition: a repository-wide history check shows that all eight candidates named here (#2365, #2429, #1756, #2050, #2827, #2364, #2712, and #2854) landed before this commit, so introducing their historical plan under _plan incorrectly presents completed work as an open unit.
AGENTS.md reference: AGENTS.md:L83-L86
Useful? React with 👍 / 👎.
| In scope for this unit and done: the bug-PR disposition, the two fixable issues, the Windows repairs, | ||
| and the devlog record. Out of scope and deliberately not started: promotion to `preview` or `main`, | ||
| `release.yml`, and npm publication. |
There was a problem hiding this comment.
Do not call this unit done until its own wp6 contract has a terminal outcome: 000_plan.md defines readiness as exact-head push CI, Service lifecycle, and Windows evidence, while 060_wp6_release_gates.md additionally specifies the still-unimplemented scripts/release.ts event-filter fix and says the train is incomplete without those gates. No final run evidence or helper patch is recorded, and lines 83–87 explicitly admit that the final-head service run is still outstanding; either finish and record wp6 before moving the unit to _fin, or label this as a partial outcome and leave the unit open.
AGENTS.md reference: AGENTS.md:L83-L86
Useful? React with 👍 / 👎.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
1 participant
Summary
Records the release-readiness train run against the
dev@47b8d1643snapshot: what the eight candidatebug pull requests turned out to be, what the fifteen triaged issues turned out to be, and the four
Windows-only defects the dispatched leg found.
Ten pull requests landed on
devduring this train, two issues closed, and five contributor PRs closedas carried or superseded. The unit is the written record of that; the code is already public history.
Why the plan document has a correction commit
The plan was audited and the audit returned FAIL on two blockers, both of which then happened in
reality:
dev.ci.ymlkeys its concurrency group ongithub.refforworkflow_dispatchas well aspush, so merging test: let the README asset check tell files from directories #2952 cancelled all four Windowsshards twenty seconds later. Every dispatch now targets a dedicated branch ref, and the cancelled
baseline is recorded as unavailable rather than quietly replaced by the later run.
enforce-targetreadiness checklist andre-drafts the PR. That checklist is an author attestation bound to an exact head, so it is not a
maintainer's to tick — which made four repaired PRs unmergeable as written. The unit now carries the
cherry-pick carry-PR path instead of merge steps that could not execute.
Keeping the correction as its own commit rather than rewriting the plan is deliberate: the audit finding
and its resolution are the useful part.
Verification
Documentation only — nothing in the build, typecheck, or test path reads from
devlog/.bun run privacy:scandoes read it, and is green.dev; it found noincorrect anchor among at least two sampled per document.
Checklist