devlog: record the #2497 credential-boundary security review

[lidge-jun]

Summary

Records the security review of #2497, the last open bug-labelled PR and the one change in
this backlog that sits on the credential boundary AGENTS.md places under explicit review.

Docs only. The PR itself is not merged — the review found three security blockers and a
red regression suite, and two of them are ownership decisions rather than defects I should
resolve inside someone else's 2,600-line credential PR.

Findings are summarized in the devlog unit and posted to #2497 for the author and maintainer.

Verification

Docs only; no code paths touched. The underlying review is recorded with file:line evidence
that I verified against the tree myself rather than taking from the reviewer.

Checklist

• Targets dev
• Based on the current dev head
• No pre-disclosure material: every finding is about an open PR's public diff, and the fix
  for each has not shipped, so nothing here discloses a weakness in released code
• No secrets, tokens, or account identifiers

Summary by CodeRabbit

• Documentation
  • Added a security review documenting outstanding authentication, credential handling, and replay-recovery concerns.
  • Recorded known test failures, required remediation areas, and an additional non-blocking data consistency concern.
  • No user-facing product changes are included in this update.

[github-actions]

✅ Deterministic PR hygiene checks passed.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 4249252d-db70-4210-838e-bec54e7d9851

📥 Commits

Reviewing files that changed from the base of the PR and between 79d932c and 33f5869.

📒 Files selected for processing (1)

• devlog/_plan/260825_owner_backlog_and_bugpr_closeout/120_wp5_2497_security_review.md

---

📝 Walkthrough

Walkthrough

Added a security review for PR #2497. The review documents three security blockers, failing tests, required remediation areas, a NEEDS_HUMAN disposition, and a non-blocking stale-identity persistence concern.

Changes

Security Review Documentation

Layer / File(s)	Summary
Security findings and merge disposition devlog/_plan/260825_owner_backlog_and_bugpr_closeout/120_wp5_2497_security_review.md:1-68	Documents non-atomic auth publication, unsafe same-account credential fallback, replay recovery that can produce up to nine physical sends, reproduced test failures, required remediation areas, and the NEEDS_HUMAN disposition. It also records a stale id_token/account-header persistence concern.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: ingwannu

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/security-review-2497

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 33f5869936

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Move the unfixed security review out of devlog

Because #2497 remains unmerged and these credential-boundary fixes have not shipped, this tracked file publicly records exact vulnerable functions, failure windows, credential-adoption behavior, and replay mechanics while the defects are still open. Move the review to .tmp/ or other scratch space and publish only the fixed outcome after it ships; an open PR containing the affected code does not make a new analysis of its weaknesses post-disclosure material.

AGENTS.md reference: AGENTS.md:L115-L119

Useful? React with 👍 / 👎.