chore: upgrade prometheus client to 1.8.0 - #1824
Open
olovy wants to merge 1 commit into
Open
Conversation
olovy
requested review from
andersju,
jannistsiroyannis,
kaipoykio,
kwahlin and
lrosenstrom
August 10, 2026 12:35
olovy
commented
Aug 10, 2026
| class NotificationListener extends Thread { | ||
| private static final String NAME = 'pg_listener' | ||
| private static final Counter counter = Counter.build() | ||
| private static final Counter counter = (Counter) Counter.builder() |
Contributor
Author
There was a problem hiding this comment.
This cast shouldn't be necessary but somehow the Groovy compiler fails here otherwise?
Same for CounterDataPoint below
olovy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade prometheus client from 0.15.0 to 1.8.0.
_totalis now a reserved prefix for counter names and cannot be used byGauge. The following metric names have been changedapi_ongoing_requests_total-->api_ongoing_requestsoaipmh_ongoing_requests_total-->oaipmh_ongoing_requestsmarc_export_api_ongoing_requests_total-->marc_export_api_ongoing_requestsstartTimer()now returns an auto-closable Timer. No moreobserveDuration()