apple: add rustynes core to App Store builds - #19416
Conversation
The RustyNES core builds cleanly for all Apple targets on the buildbot (ios-arm64, tvos-arm64, osx/arm64) but is absent from appstore_cores, so it is not bundled into the App Store builds and is unavailable to users on iOS, iPadOS and tvOS. Inserted in alphabetical order between reminiscence and sameboy.
There was a problem hiding this comment.
Pull request overview
Adds the rustynes libretro core to the Apple App Store export set so it gets bundled into iOS/iPadOS/tvOS (and macOS App Store) builds produced via the appstore path in the Apple core update script.
Changes:
- Include
rustynesinappstore_cores(kept in alphabetical order).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Flagging the two red checks — This PR changes exactly one file: a single entry added to the I couldn't read the job logs to identify the actual cause (they're not fetchable without repo access), so I'm not claiming to know what broke — only that it isn't this. For what it's worth, the comparison PRs I checked last ran their checks on Aug 12 and Aug 15, whereas this branch's run is from Aug 16, so they wouldn't reflect a recent master state either way. Happy to rebase onto current master for a fresh run if that's useful, or to leave it alone if these are known-flaky. Just let me know. |
|
@doublegate Don't worry those two CI jobs are already fixed in master, it had nothing to do with your PR |
The RustyNES core builds cleanly for every Apple target on the buildbot but is absent from
appstore_cores, so it is never bundled into the App Store builds and is unavailable to users on iOS, iPadOS and tvOS.One line, inserted in alphabetical order between
reminiscenceandsameboy:quicknes race reminiscence + rustynes sameboy sameduckThis is not a build problem
I verified the artifact before submitting rather than assuming the buildbot output was usable.
nightly/apple/ios-arm64/latest/rustynes_libretro.dylib.zip:retro_*symbols, including the full disk-control interface (retro_get_num_images,retro_set_image_index,retro_add_image_index) that the FDS multi-side support needsPresent and building on
ios-arm64,tvos-arm64andosx/arm64, so this single entry covers iOS, tvOS and the macOS App Store build.About the core
rustynesis a cycle-accurate NES/Famicom core written in Rust (libretro/RustyNESon the buildbot; info file inlibretro-super/dist/info/). Relevant to bundling:hw_render = "false"), no external runtime dependencies.savestate_features = "deterministic"— so run-ahead and RetroArch's rollback netplay both work.SET_MEMORY_MAPSfor achievements, disk control for FDS, and native Game Genie cheats.Licensing
RustyNES is GPL-3.0-or-later. Flagging it explicitly since App Store distribution is the context: this matches
mesenandbsnes_hd_beta, which are GPLv3 and already in this list, and RetroArch itself. The copyright holder is aware of and has approved App Store distribution under these terms.Two companion PRs correct the core's advertised license, which predates a relicense: libretro-super#2069 and docs#1180.
Happy to adjust anything that doesn't fit house convention.