docs(contributing): say that a claim is a courtesy, not a lock - #630
Merged
Conversation
Two contributors reached #621 ten minutes apart: it was claimed at 13:04 UTC and #627 arrived at 13:16 with a commit dated 13:14. The author of the pull request could not have seen the claim, because GitHub sends no notification for a comment on an issue you already have open. The claim bullet read as an exclusive hold and said nothing about that case, so it left the outcome looking like a judgement of one of the two people. It is not one. State the rule the collision was actually decided by: the clock rather than the claim, delivered work reviewed on its merits, nobody asked to write the same change twice, and the nearest open issue plus review credit for whoever does not land it. No test. The paragraph carries no cross-file invariant to guard, and pinning its prose verbatim would fail on the next honest edit while proving nothing. The two-week staleness window above it is unchanged and still open to review.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Two contributors reached #621 ten minutes apart. It was claimed at 13:04 UTC, and #627 arrived at 13:16 with a commit dated 13:14. A change of that shape, two providers plus both provider docs plus eight tests, is not written in ten minutes, so the work predated the claim, and its author could not have seen the claim either: GitHub sends no notification for a comment on an issue you already have open.
The claim bullet in
CONTRIBUTING.mdread as an exclusive hold and said nothing about that case, which left the outcome looking like a judgement of one of the two people. It is not one. This adds the rule the collision was actually decided by, so the next pair of contributors can read it before it happens to them rather than after:Worth noting what this exposed: the sentence contributors actually read first, "Comment to claim it before you start", is not in a template at all.
.github/ISSUE_TEMPLATE/holds onlybug_report.mdandfeature_request.md, and neither mentions claiming; the sentence is hand-copied into the body of each curated issue, where nothing in the repository can guard it. MakingCONTRIBUTING.mdthe single authority does not change the rule, but it is the first time the rule lives somewhere checkable. Repointing those issue footers at this section is a separate change.Deliberately not in this PR
No test. The paragraph carries no cross-file invariant to guard, and pinning its prose verbatim would fail on the next honest edit while proving nothing.
tests/unit/contributors-doc.test.tsguards what is guardable here, the ladder's two halves and the absence of a count, and it still passes: 9 tests, and the new bullet is a list item rather than a rung heading, so rung extraction is untouched.The staleness window is unchanged. "A claimed issue with no activity for two weeks is open again" stays as it is. Shortening it, or distinguishing a claim with a branch behind it from one without, is a policy decision rather than a wording fix, and it belongs in its own change.
Verification
bun run format,bun run lint,bun run readme:checkandbun run security:checkpass, andbun test tests/unit/contributors-doc.test.tsis 9 pass / 0 fail.