fix(delta): return errors for malformed streams - #169
Merged
genedna merged 2 commits intoJul 29, 2026
Conversation
- reject overlong size varints with InvalidData instead of shift overflow - reserve result buffer incrementally and cap output at declared result size - reuse delta_decode in Pack::rebuild_delta_with_hash and return GitError - propagate delta rebuild failures from thread pool through SharedParams - add regression tests for varint overflow, unallocatable sizes, output-size overruns, and malformed pack delta objects
genedna
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitDeltaError::DeltaDecoderErrorreturnsCloses #168
Validation
cargo fmtBINDGEN_EXTRA_CLANG_ARGS="-I/usr/lib/gcc/aarch64-linux-gnu/13/include -I/usr/include/aarch64-linux-gnu -I/usr/include" ZSTD_SYS_USE_PKG_CONFIG=1 cargo test delta::decodeBINDGEN_EXTRA_CLANG_ARGS="-I/usr/lib/gcc/aarch64-linux-gnu/13/include -I/usr/include/aarch64-linux-gnu -I/usr/include" ZSTD_SYS_USE_PKG_CONFIG=1 cargo testBINDGEN_EXTRA_CLANG_ARGS="-I/usr/lib/gcc/aarch64-linux-gnu/13/include -I/usr/include/aarch64-linux-gnu -I/usr/include" ZSTD_SYS_USE_PKG_CONFIG=1 cargo clippy --all-targets -- -D warnings