fix(rendezvous): cancel superseded registration timers - #6620
Merged
Merged
Conversation
Harden the client by capping the TTL at `MAX_TTL` before constructing the expiry timer.
Member
Author
|
to be merged after #6619 |
Re-registering the same (peer, namespace) or unregistering replaced the registration in the BiMap but left the previous expiry `Delay` future in `FuturesUnordered` until it fired, up to `max_ttl` later. A peer that re-registers at a steady rate causes unbounded timer accumulation on the server. Wrap each expiry timer in an `Abortable` and keep its `AbortHandle`. When a registration is superseded or unregistered, abort the previous timer so it is dropped on the next poll instead of lingering. Also prune the superseded registration's id from the pagination cookies, which the expired timer used to clean up when it fired.
jxs
force-pushed
the
fix/rendezvous-registrations
branch
from
September 14, 2026 15:49
8d3ef9e to
973156c
Compare
Contributor
|
This pull request has merge conflicts. Could you please resolve them @jxs? 🙏 |
jxs
force-pushed
the
fix/rendezvous-registrations
branch
from
September 16, 2026 09:18
f484c60 to
d4afcc1
Compare
Contributor
Merge Queue Status
This pull request spent 7 minutes 19 seconds in the queue, including 6 minutes 41 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-registering the same (peer, namespace) or unregistering replaced the
registration in the BiMap but left the previous expiry
Delayfuture inFuturesUnordereduntil it fired, up tomax_ttllater. A peer thatre-registers at a steady rate causes unbounded timer accumulation on the
server.
Wrap each expiry timer in an
Abortableand keep itsAbortHandle. Whena registration is superseded or unregistered, abort the previous timer so
it is dropped on the next poll instead of lingering. Also prune the
superseded registration's id from the pagination cookies, which the
expired timer used to clean up when it fired.