fix(popup): detect departure without interrupting pending recovery - #36
Merged
Merged
Conversation
Report participating document departure and detect unavailable consent windows when no carrier or recovery remains. Preserve pending handshake acknowledgements through COOP fallback, ignore retired-carrier messages, and retain protocol version 1 for the unpublished package. Signed-off-by: Wondertan <hlibwondertan@gmail.com> Assisted-by: GPT-6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing a participating popup or losing its consent-page window could leave the application waiting indefinitely. Report document departure over the existing carrier and detect an unavailable retained window when no carrier, pending handshake, or fallback recovery remains. Planned navigation preserves the connection; COOP severance during a queued handshake acknowledgement does not prematurely end recovery.
closedreports the logical connection outcome. A lost window handle cannot distinguish user closure from provider COOP; isolated/openerless departure remains best-effort. Keep the unpublished transport version at 1.Validation: 127 unit tests and 143 Playwright cases passed across Chromium, Firefox, WebKit and mobile emulation; two existing skips. Type and export checks passed. The regression tests cover the pending-acknowledgement race and departure/closure handling.
Ceremony implementation #28 is stacked on this change.