chore: take libid-profiles 0.13, where github reveals its token request whole - #25
Draft
SupremaLex wants to merge 1 commit into
Draft
SupremaLex wants to merge 1 commit into
SupremaLex wants to merge 1 commit into
Conversation
`capture_ceremony` defaults its redirect URI to `http://127.0.0.1:8722/auth/callback`, the path the bridge serves, and listens on the matching address. One app registration per platform is then enough to capture from, and the two values move together. A path naming its platform bought nothing: the profile fixes what the redirect URI must equal, not what it must be, and no ceremony reads it. `--redirect-uri` and `--listen` still override the pair for an app registered elsewhere. Assisted-by: Claude Opus 5 Signed-off-by: SupremaLex <georglutsenko@gmail.com>
xgreenx
added a commit
that referenced
this pull request
Sep 17, 2026
`libid-tlsn` exports `AbortOnDrop`, the guard every session driver needs (#26); the attested-data record moves to `libid_transcript::attestation`, beside the wire that carries it, and `libid-tlsn` no longer depends on `libid-ceremony`, which re-exports the old paths (#27); repository names are canonical (#25). Assisted-by: Claude Fable 5.1 Signed-off-by: xgreenx <xgreenx9999@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft until libid-contracts publishes
libid-profiles 0.13.0, which is where GitHub's token request becomes one revealed range with no committed suffix — the shape X already has. The profile table is generated there and reaches this crate through crates.io, so this branch lands in two steps.In this branch now
capture_ceremonydefaults to one redirect URI for every platform,http://127.0.0.1:8722/auth/callback, the path the bridge serves, and listens on the matching address. One app registration per platform is enough to capture from, and the two values move together;--redirect-uri/--listenstill override the pair. Independent of the profile change and green against0.10.Once
0.13.0is on crates.iolibid-profilesandlibid-identityto0.13(0.11/0.12are content-identical to0.10, so this is a pure pin bump like chore: take libid-profiles and libid-identity 0.10 #22).Layout::token_request(sent) -> Layout: no profile argument and infallible, sinceTokenSessionhas nosecret_fieldafter refactor(ceremony): the token request commits nothing, as a rule libID-contracts#45;LayoutError::MissingCredentialand the committing-path tests go, nine call sites follow.the_github_exchange_is_revealed_whole,attest.rsandceremony_end_to_end.rsassert zero sent commitments and the credential present in the revealed bytes. Already written, verified green against that branch's crate, and held for the pin commit.cargo run -p libid-tlsn --example ceremony_fixturesagainst the published crate must reproduce byte for byte thegithub-ceremony-session.jsonthe contracts PR carries.Order across the repos
secret_fieldleavesTokenSession.release/v0.13.0merges and the release publishes the crate.