Repository navigation
Conversation
REQ-PLAT-06 requires an X or GitHub id to match ^[1-9][0-9]{0,19}$
with a value at most 2^64 - 1. The X reader returned any string between
the quotes and the GitHub reader accepted 0 and ids past uint64, so the
registry could record an id the browser and the spec refuse. Both now
revert with NoncanonicalUserId. The reference copy takes the rule too,
so the differential tests still hold. Costs 1.4k gas per GitHub claim
and 2.8k per X claim.
Assisted-by: Claude Opus 5.5
Signed-off-by: xgreenx <xgreenx9999@gmail.com>
The base holds every profile's id to REQ-PLAT-06, so a new profile learns the rule from the _identityFields doc rather than a revert. The GitHub test that rejects 0 takes the X test's name: 0 is inside uint64 but outside the grammar. The reference copy's doc names its one change the way the file's other library does. Assisted-by: Claude Opus 5.5 Signed-off-by: xgreenx <xgreenx9999@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The X and GitHub Platform Verifiers recorded ids that REQ-PLAT-06 and the browser refuse: X took any string between the quotes, GitHub took
0and ids past2^64 - 1.Changes
CeremonyFields.isCanonicalNonzeroUint64(CeremonyFields.sol:577) holds an id to^[1-9][0-9]{0,19}$, at most2^64 - 1.TlsNotaryVerifierBaserevertsNoncanonicalUserId(bytes)on any other id (TlsNotaryVerifierBase.sol:447), for both profiles; REQ-PLAT-08's rejections stay.test_zeroIsCanonicalbecomestest_readsZeroWhichIsNoUserId; unit and verifier tests cover 0, leading zero, 21 digits,2^64 - 1accepted,2^64rejected, non-digit X ids.TranscriptReference.solcarries the rule as a digit scan; a differential fuzz (TranscriptEquivalence.t.sol:971) compares the two._identityFieldsstates the id rule a new profile must meet.Verified
forge fmt --check,forge build,forge lint -D notes: clean.forge test: 39 suites, 662 tests pass.cargo test --all: 38 tests pass.< 10^20) fail the unit, verifier and differential tests.Not verified / known issues
🤖 Generated with Claude Code