Repository navigation
docs(ceremony): cite the spec sections the code follows - #84
Merged
Merged
Conversation
The specification now holds X's whole token body to REQ-PLAT-63's exact five-field form, as it holds GitHub's to REQ-PLAT-61, and no launch profile depends on ASM-PROV-07. The profile notes and the generated constants still said X's specification rested on that assumption. Assisted-by: Claude Opus 5.5 Signed-off-by: xgreenx <xgreenx9999@gmail.com>
Ceremony-common section 9.1 holds the verification and fee rules, not the attested-data bytes, which platform-ceremonies section 4.1 defines. Section 9.2 does not exist, and REQ-COMMON-49 is REQ-COMMON-33. Assisted-by: Claude Opus 5.5 Signed-off-by: xgreenx <xgreenx9999@gmail.com>
The case changes ceremonyVersion, which is the Platform Ceremony Version. The Verifier Version is not in the Authorization Digest. Assisted-by: Claude Opus 5.5 Signed-off-by: xgreenx <xgreenx9999@gmail.com>
bind records every accepted digest in spentDigests and refuses a repeat (REQ-COMMON-03, REQ-COMMON-03A). The contract doc and a test comment still said there was no nullifier. Assisted-by: Claude Opus 5.5 Signed-off-by: xgreenx <xgreenx9999@gmail.com>
Platform-ceremonies section 4.1 scopes the attested-data layout to the X and GitHub profiles. The Google Platform Verifier consumes no notarized record, and its tests build none. Assisted-by: Claude Opus 5.5 Signed-off-by: xgreenx <xgreenx9999@gmail.com>
test_aDigestIsSpendableOnce lives in CeremonyBind.t.sol, not beside the comment that cites it. Assisted-by: Claude Opus 5.5 Signed-off-by: xgreenx <xgreenx9999@gmail.com>
The verifier refuses the encoded duplicate under REQ-PLAT-63, and TEST-PLAT-09C is the vector. The GitHub sibling opens the same way with REQ-PLAT-61 and TEST-PLAT-12. Assisted-by: Claude Opus 5.5 Signed-off-by: xgreenx <xgreenx9999@gmail.com>
The header said the layout was an unpublished agreement between four components. Platform-ceremonies section 4.1 now publishes it for the X and GitHub profiles, which the other citations on this branch follow. Assisted-by: Claude Opus 5.5 Signed-off-by: xgreenx <xgreenx9999@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments and one test message cite spec sections and rules that are outdated or do not exist. No behaviour change.
Follows libid-org/libID#112, which adds platform-ceremonies section 4.1 "Attested data". Merge this after it.
Changes
XPlatformVerifiercite REQ-PLAT-63 instead of "stricter than the specification on ASM-PROV-07"; source isprofiles.json+regen-ceremony-profiles.py.INotaryService,GoogleJwtRoots,CeremonyAttestationand four test files cite platform-ceremonies section 4.1, scoped to X and GitHub; ceremony-common 9.1 holds the verification rules.NotaryService.t.sol:12: section 9.2 does not exist; cites 9.1.Deploy.s.sol:51: REQ-COMMON-49 does not exist; cites REQ-COMMON-33.CeremonyAuthorization.t.sol:79: the message names the Platform Ceremony Version, the value the case changes.IdentityRegistry.sol:81: the Authorization Digest is the nullifier (spentDigests, REQ-COMMON-03/03A); theobservedAtwatermark stops older proofs.Verified
forge fmt --check,forge build,forge lint -D notespass.forge test: 653 passed, 0 failed.regen-*.py --checkreport no drift.Not verified / known issues
GoogleJwtRootsdoes decode it so.🤖 Generated with Claude Code