Repository navigation
ci(deploy): each network signs with its own deployer key - #83
Merged
Merged
Conversation
The resolver deploy named one key and one role of an AWS account that no longer exists. Each network has its own deployer key in its own account: `testnet` signs with alias/libid-testnet-deployer, the owner of `testnet.handles.link`, and `mainnet` with alias/libid-mainnet-deployer, the owner of `handles.link`. The role comes from the environment's AWS_DEPLOYER_ROLE_ARN secret, and the name to point is asked for rather than defaulted, since it differs by network. Assisted-by: Claude Fable 5.1 Signed-off-by: Green Baneling <XgreenX9999@gmail.com>
Contributor
Author
|
Dry run on |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Deploy the ENS resolver" named one key and one role of an AWS account that no longer exists, so it could not run. Each network has its own deployer key in its own account.
Changes
alias/libid-<network>-deployer.testnetsigns as the owner oftestnet.handles.link,mainnetas the owner ofhandles.link.AWS_DEPLOYER_ROLE_ARNsecret, now set ontestnetandmainnetto the roles of https://github.com/grndd-systems/deployment/pull/130.ens_name: required, no default, since the name differs by network.Verified
testnetfrom this branch: the role is assumed, the signer is the testnet deployer, and it ownstestnet.handles.linkon Sepolia (run linked in a comment).Not verified / known issues
mainnet: a dry run waits for a reviewer's approval.ENS_RPC_URLis set on neither environment, so a run takesrpc_url.Assisted-by: Claude Fable 5.1