Skip to content

Close weak headers DoS surface. #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 3 commits into from
Sep 23, 2026
Merged

Close weak headers DoS surface. #1147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57b23cf
Drop blocks-first synchronization and fold the organizer into the hea…
evoskuil Sep 23, 2026
548a3d4
Close weak headers DoS surface.
evoskuil Sep 23, 2026
5eb9f2c
Prove header branches against candidate-relative minimum work.
evoskuil Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions builds/gnu/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ src_libbitcoin_node_la_SOURCES = \
${srcdir}/../../src/settings.cpp \
${srcdir}/../../src/channels/channel_peer.cpp \
${srcdir}/../../src/chasers/chaser.cpp \
${srcdir}/../../src/chasers/chaser_block.cpp \
${srcdir}/../../src/chasers/chaser_check.cpp \
${srcdir}/../../src/chasers/chaser_confirm.cpp \
${srcdir}/../../src/chasers/chaser_estimate.cpp \
Expand All @@ -73,9 +72,7 @@ src_libbitcoin_node_la_SOURCES = \
${srcdir}/../../src/chasers/chaser_validate_capture.cpp \
${srcdir}/../../src/chasers/chaser_validate_parallel.cpp \
${srcdir}/../../src/protocols/protocol.cpp \
${srcdir}/../../src/protocols/protocol_block_in_106.cpp \
${srcdir}/../../src/protocols/protocol_block_in_31800.cpp \
${srcdir}/../../src/protocols/protocol_block_in_70001.cpp \
${srcdir}/../../src/protocols/protocol_block_out_106.cpp \
${srcdir}/../../src/protocols/protocol_block_out_70001.cpp \
${srcdir}/../../src/protocols/protocol_block_out_70012.cpp \
Expand Down Expand Up @@ -133,25 +130,17 @@ include_bitcoin_node_chasersdir = \

include_bitcoin_node_chasers_HEADERS = \
${srcdir}/../../include/bitcoin/node/chasers/chaser.hpp \
${srcdir}/../../include/bitcoin/node/chasers/chaser_block.hpp \
${srcdir}/../../include/bitcoin/node/chasers/chaser_check.hpp \
${srcdir}/../../include/bitcoin/node/chasers/chaser_confirm.hpp \
${srcdir}/../../include/bitcoin/node/chasers/chaser_estimate.hpp \
${srcdir}/../../include/bitcoin/node/chasers/chaser_header.hpp \
${srcdir}/../../include/bitcoin/node/chasers/chaser_organize.hpp \
${srcdir}/../../include/bitcoin/node/chasers/chaser_snapshot.hpp \
${srcdir}/../../include/bitcoin/node/chasers/chaser_storage.hpp \
${srcdir}/../../include/bitcoin/node/chasers/chaser_template.hpp \
${srcdir}/../../include/bitcoin/node/chasers/chaser_transaction.hpp \
${srcdir}/../../include/bitcoin/node/chasers/chaser_validate.hpp \
${srcdir}/../../include/bitcoin/node/chasers/chasers.hpp

include_bitcoin_node_impl_chasersdir = \
${includedir}/bitcoin/node/impl/chasers

include_bitcoin_node_impl_chasers_HEADERS = \
${srcdir}/../../include/bitcoin/node/impl/chasers/chaser_organize.ipp

include_bitcoin_node_impl_sessionsdir = \
${includedir}/bitcoin/node/impl/sessions

Expand All @@ -163,9 +152,7 @@ include_bitcoin_node_protocolsdir = \

include_bitcoin_node_protocols_HEADERS = \
${srcdir}/../../include/bitcoin/node/protocols/protocol.hpp \
${srcdir}/../../include/bitcoin/node/protocols/protocol_block_in_106.hpp \
${srcdir}/../../include/bitcoin/node/protocols/protocol_block_in_31800.hpp \
${srcdir}/../../include/bitcoin/node/protocols/protocol_block_in_70001.hpp \
${srcdir}/../../include/bitcoin/node/protocols/protocol_block_out_106.hpp \
${srcdir}/../../include/bitcoin/node/protocols/protocol_block_out_70001.hpp \
${srcdir}/../../include/bitcoin/node/protocols/protocol_block_out_70012.hpp \
Expand Down Expand Up @@ -232,7 +219,6 @@ test_libbitcoin_node_test_SOURCES = \
${srcdir}/../../test/settings.cpp \
${srcdir}/../../test/test.cpp \
${srcdir}/../../test/chasers/chaser.cpp \
${srcdir}/../../test/chasers/chaser_block.cpp \
${srcdir}/../../test/chasers/chaser_check.cpp \
${srcdir}/../../test/chasers/chaser_confirm.cpp \
${srcdir}/../../test/chasers/chaser_estimate.cpp \
Expand Down
1 change: 0 additions & 1 deletion builds/msvc/vs2026/libbitcoin-node-test/libbitcoin-node-test.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@
<ClCompile Include="..\..\..\..\test\block_memory.cpp" />
<ClCompile Include="..\..\..\..\test\channel_peer.cpp" />
<ClCompile Include="..\..\..\..\test\chasers\chaser.cpp" />
<ClCompile Include="..\..\..\..\test\chasers\chaser_block.cpp" />
<ClCompile Include="..\..\..\..\test\chasers\chaser_check.cpp" />
<ClCompile Include="..\..\..\..\test\chasers\chaser_confirm.cpp" />
<ClCompile Include="..\..\..\..\test\chasers\chaser_estimate.cpp" />
Expand Down
3 changes: 0 additions & 3 deletions builds/msvc/vs2026/libbitcoin-node-test/libbitcoin-node-test.vcxproj.filters
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@
<ClCompile Include="..\..\..\..\test\chasers\chaser.cpp">
<Filter>src\chasers</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\test\chasers\chaser_block.cpp">
<Filter>src\chasers</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\test\chasers\chaser_check.cpp">
<Filter>src\chasers</Filter>
</ClCompile>
Expand Down
8 changes: 0 additions & 8 deletions builds/msvc/vs2026/libbitcoin-node/libbitcoin-node.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@
<ClCompile Include="..\..\..\..\src\block_memory.cpp" />
<ClCompile Include="..\..\..\..\src\channels\channel_peer.cpp" />
<ClCompile Include="..\..\..\..\src\chasers\chaser.cpp" />
<ClCompile Include="..\..\..\..\src\chasers\chaser_block.cpp" />
<ClCompile Include="..\..\..\..\src\chasers\chaser_check.cpp" />
<ClCompile Include="..\..\..\..\src\chasers\chaser_confirm.cpp" />
<ClCompile Include="..\..\..\..\src\chasers\chaser_estimate.cpp" />
Expand All @@ -143,9 +142,7 @@
<ClCompile Include="..\..\..\..\src\estimator.cpp" />
<ClCompile Include="..\..\..\..\src\full_node.cpp" />
<ClCompile Include="..\..\..\..\src\protocols\protocol.cpp" />
<ClCompile Include="..\..\..\..\src\protocols\protocol_block_in_106.cpp" />
<ClCompile Include="..\..\..\..\src\protocols\protocol_block_in_31800.cpp" />
<ClCompile Include="..\..\..\..\src\protocols\protocol_block_in_70001.cpp" />
<ClCompile Include="..\..\..\..\src\protocols\protocol_block_out_106.cpp" />
<ClCompile Include="..\..\..\..\src\protocols\protocol_block_out_70001.cpp" />
<ClCompile Include="..\..\..\..\src\protocols\protocol_block_out_70012.cpp" />
Expand Down Expand Up @@ -179,12 +176,10 @@
<ClInclude Include="..\..\..\..\include\bitcoin\node\channels\channels.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\node\chase.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\node\chasers\chaser.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\node\chasers\chaser_block.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\node\chasers\chaser_check.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\node\chasers\chaser_confirm.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\node\chasers\chaser_estimate.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\node\chasers\chaser_header.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\node\chasers\chaser_organize.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\node\chasers\chaser_snapshot.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\node\chasers\chaser_storage.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\node\chasers\chaser_template.hpp" />
Expand All @@ -198,9 +193,7 @@
<ClInclude Include="..\..\..\..\include\bitcoin\node\events.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\node\full_node.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\node\protocols\protocol.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\node\protocols\protocol_block_in_106.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\node\protocols\protocol_block_in_31800.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\node\protocols\protocol_block_in_70001.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\node\protocols\protocol_block_out_106.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\node\protocols\protocol_block_out_70001.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\node\protocols\protocol_block_out_70012.hpp" />
Expand Down Expand Up @@ -229,7 +222,6 @@
<ClInclude Include="..\..\..\..\include\bitcoin\node\version.hpp" />
</ItemGroup>
<ItemGroup>
<None Include="..\..\..\..\include\bitcoin\node\impl\chasers\chaser_organize.ipp" />
<None Include="..\..\..\..\include\bitcoin\node\impl\sessions\session_peer.ipp" />
<None Include="packages.config" />
</ItemGroup>
Expand Down
45 changes: 9 additions & 36 deletions builds/msvc/vs2026/libbitcoin-node/libbitcoin-node.vcxproj.filters
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,35 +25,32 @@
<Filter Include="include\bitcoin\node\impl">
<UniqueIdentifier>{5FFB5F52-0772-4404-0000-000000000005}</UniqueIdentifier>
</Filter>
<Filter Include="include\bitcoin\node\impl\chasers">
<UniqueIdentifier>{5FFB5F52-0772-4404-0000-000000000006}</UniqueIdentifier>
</Filter>
<Filter Include="include\bitcoin\node\impl\sessions">
<UniqueIdentifier>{5FFB5F52-0772-4404-0000-000000000007}</UniqueIdentifier>
<UniqueIdentifier>{5FFB5F52-0772-4404-0000-000000000006}</UniqueIdentifier>
</Filter>
<Filter Include="include\bitcoin\node\protocols">
<UniqueIdentifier>{5FFB5F52-0772-4404-0000-000000000008}</UniqueIdentifier>
<UniqueIdentifier>{5FFB5F52-0772-4404-0000-000000000007}</UniqueIdentifier>
</Filter>
<Filter Include="include\bitcoin\node\sessions">
<UniqueIdentifier>{5FFB5F52-0772-4404-0000-000000000009}</UniqueIdentifier>
<UniqueIdentifier>{5FFB5F52-0772-4404-0000-000000000008}</UniqueIdentifier>
</Filter>
<Filter Include="resource">
<UniqueIdentifier>{5FFB5F52-0772-4404-0000-00000000000A}</UniqueIdentifier>
<UniqueIdentifier>{5FFB5F52-0772-4404-0000-000000000009}</UniqueIdentifier>
</Filter>
<Filter Include="src">
<UniqueIdentifier>{5FFB5F52-0772-4404-0000-00000000000B}</UniqueIdentifier>
<UniqueIdentifier>{5FFB5F52-0772-4404-0000-00000000000A}</UniqueIdentifier>
</Filter>
<Filter Include="src\channels">
<UniqueIdentifier>{5FFB5F52-0772-4404-0000-00000000000C}</UniqueIdentifier>
<UniqueIdentifier>{5FFB5F52-0772-4404-0000-00000000000B}</UniqueIdentifier>
</Filter>
<Filter Include="src\chasers">
<UniqueIdentifier>{5FFB5F52-0772-4404-0000-00000000000D}</UniqueIdentifier>
<UniqueIdentifier>{5FFB5F52-0772-4404-0000-00000000000C}</UniqueIdentifier>
</Filter>
<Filter Include="src\protocols">
<UniqueIdentifier>{5FFB5F52-0772-4404-0000-00000000000E}</UniqueIdentifier>
<UniqueIdentifier>{5FFB5F52-0772-4404-0000-00000000000D}</UniqueIdentifier>
</Filter>
<Filter Include="src\sessions">
<UniqueIdentifier>{5FFB5F52-0772-4404-0000-00000000000F}</UniqueIdentifier>
<UniqueIdentifier>{5FFB5F52-0772-4404-0000-00000000000E}</UniqueIdentifier>
</Filter>
</ItemGroup>
<ItemGroup>
Expand All @@ -69,9 +66,6 @@
<ClCompile Include="..\..\..\..\src\chasers\chaser.cpp">
<Filter>src\chasers</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\src\chasers\chaser_block.cpp">
<Filter>src\chasers</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\src\chasers\chaser_check.cpp">
<Filter>src\chasers</Filter>
</ClCompile>
Expand Down Expand Up @@ -123,15 +117,9 @@
<ClCompile Include="..\..\..\..\src\protocols\protocol.cpp">
<Filter>src\protocols</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\src\protocols\protocol_block_in_106.cpp">
<Filter>src\protocols</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\src\protocols\protocol_block_in_31800.cpp">
<Filter>src\protocols</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\src\protocols\protocol_block_in_70001.cpp">
<Filter>src\protocols</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\src\protocols\protocol_block_out_106.cpp">
<Filter>src\protocols</Filter>
</ClCompile>
Expand Down Expand Up @@ -227,9 +215,6 @@
<ClInclude Include="..\..\..\..\include\bitcoin\node\chasers\chaser.hpp">
<Filter>include\bitcoin\node\chasers</Filter>
</ClInclude>
<ClInclude Include="..\..\..\..\include\bitcoin\node\chasers\chaser_block.hpp">
<Filter>include\bitcoin\node\chasers</Filter>
</ClInclude>
<ClInclude Include="..\..\..\..\include\bitcoin\node\chasers\chaser_check.hpp">
<Filter>include\bitcoin\node\chasers</Filter>
</ClInclude>
Expand All @@ -242,9 +227,6 @@
<ClInclude Include="..\..\..\..\include\bitcoin\node\chasers\chaser_header.hpp">
<Filter>include\bitcoin\node\chasers</Filter>
</ClInclude>
<ClInclude Include="..\..\..\..\include\bitcoin\node\chasers\chaser_organize.hpp">
<Filter>include\bitcoin\node\chasers</Filter>
</ClInclude>
<ClInclude Include="..\..\..\..\include\bitcoin\node\chasers\chaser_snapshot.hpp">
<Filter>include\bitcoin\node\chasers</Filter>
</ClInclude>
Expand Down Expand Up @@ -284,15 +266,9 @@
<ClInclude Include="..\..\..\..\include\bitcoin\node\protocols\protocol.hpp">
<Filter>include\bitcoin\node\protocols</Filter>
</ClInclude>
<ClInclude Include="..\..\..\..\include\bitcoin\node\protocols\protocol_block_in_106.hpp">
<Filter>include\bitcoin\node\protocols</Filter>
</ClInclude>
<ClInclude Include="..\..\..\..\include\bitcoin\node\protocols\protocol_block_in_31800.hpp">
<Filter>include\bitcoin\node\protocols</Filter>
</ClInclude>
<ClInclude Include="..\..\..\..\include\bitcoin\node\protocols\protocol_block_in_70001.hpp">
<Filter>include\bitcoin\node\protocols</Filter>
</ClInclude>
<ClInclude Include="..\..\..\..\include\bitcoin\node\protocols\protocol_block_out_106.hpp">
<Filter>include\bitcoin\node\protocols</Filter>
</ClInclude>
Expand Down Expand Up @@ -373,9 +349,6 @@
</ClInclude>
</ItemGroup>
<ItemGroup>
<None Include="..\..\..\..\include\bitcoin\node\impl\chasers\chaser_organize.ipp">
<Filter>include\bitcoin\node\impl\chasers</Filter>
</None>
<None Include="..\..\..\..\include\bitcoin\node\impl\sessions\session_peer.ipp">
<Filter>include\bitcoin\node\impl\sessions</Filter>
</None>
Expand Down
4 changes: 0 additions & 4 deletions include/bitcoin/node.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,22 +31,18 @@
#include <bitcoin/node/channels/channel_peer.hpp>
#include <bitcoin/node/channels/channels.hpp>
#include <bitcoin/node/chasers/chaser.hpp>
#include <bitcoin/node/chasers/chaser_block.hpp>
#include <bitcoin/node/chasers/chaser_check.hpp>
#include <bitcoin/node/chasers/chaser_confirm.hpp>
#include <bitcoin/node/chasers/chaser_estimate.hpp>
#include <bitcoin/node/chasers/chaser_header.hpp>
#include <bitcoin/node/chasers/chaser_organize.hpp>
#include <bitcoin/node/chasers/chaser_snapshot.hpp>
#include <bitcoin/node/chasers/chaser_storage.hpp>
#include <bitcoin/node/chasers/chaser_template.hpp>
#include <bitcoin/node/chasers/chaser_transaction.hpp>
#include <bitcoin/node/chasers/chaser_validate.hpp>
#include <bitcoin/node/chasers/chasers.hpp>
#include <bitcoin/node/protocols/protocol.hpp>
#include <bitcoin/node/protocols/protocol_block_in_106.hpp>
#include <bitcoin/node/protocols/protocol_block_in_31800.hpp>
#include <bitcoin/node/protocols/protocol_block_in_70001.hpp>
#include <bitcoin/node/protocols/protocol_block_out_106.hpp>
#include <bitcoin/node/protocols/protocol_block_out_70001.hpp>
#include <bitcoin/node/protocols/protocol_block_out_70012.hpp>
Expand Down
11 changes: 0 additions & 11 deletions include/bitcoin/node/chase.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,6 @@ enum class chase
/// Candidate Chain.
/// -----------------------------------------------------------------------

/// A new candidate branch exists from given branch point.
/// Issued by 'block' and handled by none.
blocks,

/// A new candidate branch exists from given branch point.
/// Issued by 'header' and handled by 'check'.
headers,
Expand Down Expand Up @@ -257,12 +253,6 @@ struct report
count_t sequence;
};

struct blocks
{
static constexpr chase id{ chase::blocks };
height_t branch_point;
};

struct headers
{
static constexpr chase id{ chase::headers };
Expand Down Expand Up @@ -386,7 +376,6 @@ using event_value = std::variant
chases::stall,
chases::purge,
chases::report,
chases::blocks,
chases::headers,
chases::download,
chases::regressed,
Expand Down
81 changes: 0 additions & 81 deletions include/bitcoin/node/chasers/chaser_block.hpp
View file
Open in desktop

This file was deleted.

Loading
Loading