Skip to content

Fix for OSX clang++ warning#4436

Open
roystgnr wants to merge 1 commit intolibMesh:develfrom
roystgnr:os_26_4_warnings
Open

Fix for OSX clang++ warning#4436
roystgnr wants to merge 1 commit intolibMesh:develfrom
roystgnr:os_26_4_warnings

Conversation

@roystgnr
Copy link
Copy Markdown
Member

The compiler noticed (at least in my personal --paranoid-warnings builds) that we have a method marked virtual despite being in a class marked final from which we can never override it. It kinda has a point.

The compiler noticed that we have a method marked virtual despite
being in a class marked final from which we can never override it.  It
kinda has a point.
@moosebuild
Copy link
Copy Markdown

Job Coverage, step Generate coverage on 13501bc wanted to post the following:

Coverage

0185b8 #4436 13501b
Total Total +/- New
Rate 65.47% 65.47% -0.00% -
Hits 78227 78226 -1 0
Misses 41254 41255 +1 0

Diff coverage report

Full coverage report

This comment will be updated on new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants