chore: rename repo URLs + rebrand remaining devops-bootcamp references (#827) - #933
Open
gdsmith1 wants to merge 2 commits into
Open
chore: rename repo URLs + rebrand remaining devops-bootcamp references (#827)#933gdsmith1 wants to merge 2 commits into
gdsmith1 wants to merge 2 commits into
Conversation
Sweep replaces every github.com/liatrio/devops-bootcamp reference with github.com/liatrio/engineering-bootcamp outside docs/specs/**. Includes Go module path rewrites in examples/ch8 (+ examples/ch11/data-patterns/**) and go.mod tidy. Adds a replace directive in examples/ch8/devops-api/go.mod pointing the renamed sibling module at ../devops-resources — the old pinned commit hash is not resolvable on the renamed remote. Related to T4 in Spec 04
Contributor
📝 WalkthroughWalkthroughUpdated repository URLs and Go module paths throughout documentation, examples, configuration, imports, and test fixtures from ChangesRepository Rename References
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/6-software-development-practices/6.5.1-unit-testing.md`:
- Around line 89-90: Update the Repository field in both fixtures in the
unit-testing documentation to match the repository named by their Url, replacing
the stale devops-bootcamp value with engineering-bootcamp while leaving the
other metadata unchanged.
In `@examples/ch8/devops-api/update.go`:
- Line 8: Align the devops-resources module path consistently across the Ch8
project, using examples/ch8/devops-resources as the canonical path documented by
the README. Update the module declaration, the import in the Ch8 API, all
related replace/require entries, and documentation references; do not leave any
examples/ch7/devops-resources references in the Ch8 files.
In `@examples/ch8/devops-resources/README.md`:
- Line 20: Update the go.mod example in the README to use the plural module path
examples/ch8/devops-resources, matching the actual module/import path.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: ee7e719b-2b9e-4c0a-b20a-9a3827815610
⛔ Files ignored due to path filters (1)
examples/ch8/devops-api/go.sumis excluded by!**/*.sum
📒 Files selected for processing (27)
.github/prompts/new-section.prompt.mddocs/11-application-development/11.2.1-solid-principles.mddocs/5-cloud-computing/5.2.6-ecs.mddocs/6-software-development-practices/6.5.1-unit-testing.mddocs/7-release-management/7.2.2-maven-integration.mddocs/8-infrastructure-configuration-management/8.3-terraform-providers.mddocs/9-kubernetes-container-orchestration/9.2-volumes.mddocs/9-kubernetes-container-orchestration/9.5-hpas.mddocs/9-kubernetes-container-orchestration/9.7-webhooks.mddocs/9-kubernetes-container-orchestration/9.9-controllers.mdexamples/ch11/data-patterns/active-record/go.modexamples/ch11/data-patterns/concurrency/optimistic/go.modexamples/ch11/data-patterns/concurrency/pessimistic/go.modexamples/ch11/data-patterns/repository-exercise-starter/go.modexamples/ch11/data-patterns/repository/go.modexamples/ch8/devops-api/create.goexamples/ch8/devops-api/delete.goexamples/ch8/devops-api/go.modexamples/ch8/devops-api/main.goexamples/ch8/devops-api/main_test.goexamples/ch8/devops-api/read.goexamples/ch8/devops-api/update.goexamples/ch8/devops-resources/README.mdexamples/ch8/devops-resources/go.modexamples/codeQuality/goExamples/example_test.goindex.htmlpackage.json
|
|
||
| "github.com/gin-gonic/gin" | ||
| "github.com/liatrio/devops-bootcamp/examples/ch7/devops-resources" | ||
| "github.com/liatrio/engineering-bootcamp/examples/ch7/devops-resources" |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
rg -n '^module ' examples/ch8/devops-resources/go.mod
rg -n 'engineering-bootcamp/examples/ch[78]/devops-resources' examples/ch8/devops-api examples/ch8/devops-resourcesRepository: liatrio/engineering-bootcamp
Length of output: 1427
🏁 Script executed:
#!/bin/bash
sed -n '1,120p' examples/ch8/devops-resources/README.md
printf '\n--- go.mod files ---\n'
sed -n '1,20p' examples/ch8/devops-resources/go.mod
printf '\n'
sed -n '1,20p' examples/ch8/devops-api/go.mod
printf '\n--- imports using examples/ch7 or examples/ch8 ---\n'
rg -n 'examples/ch[78]/devops-resources|examples/ch[78]/devops' examples/ch8/devops-api examples/ch8/devops-resourcesRepository: liatrio/engineering-bootcamp
Length of output: 4873
Align the devops-resources module path across all files.
examples/ch8/devops-resources/go.mod declares examples/ch7/devops-resources, but the README documents examples/ch8/devops-resources while the Ch8 API uses examples/ch7. Pick one canonical path and update the module declaration, imports, replaces/requirements, and docs consistently.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@examples/ch8/devops-api/update.go` at line 8, Align the devops-resources
module path consistently across the Ch8 project, using
examples/ch8/devops-resources as the canonical path documented by the README.
Update the module declaration, the import in the Ch8 API, all related
replace/require entries, and documentation references; do not leave any
examples/ch7/devops-resources references in the Ch8 files.
|
|
||
| ```go | ||
| require github.com/liatrio/devops-bootcamp/examples/ch8/devops-resource [branch] | ||
| require github.com/liatrio/engineering-bootcamp/examples/ch8/devops-resource [branch] |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Use the plural module path in the go.mod example.
The example now references .../examples/ch8/devops-resource, but the actual module/import path is .../examples/ch8/devops-resources. Following this example will resolve the wrong module.
Proposed fix
-require github.com/liatrio/engineering-bootcamp/examples/ch8/devops-resource [branch]
+require github.com/liatrio/engineering-bootcamp/examples/ch8/devops-resources [branch]📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| require github.com/liatrio/engineering-bootcamp/examples/ch8/devops-resource [branch] | |
| require github.com/liatrio/engineering-bootcamp/examples/ch8/devops-resources [branch] |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@examples/ch8/devops-resources/README.md` at line 20, Update the go.mod
example in the README to use the plural module path
examples/ch8/devops-resources, matching the actual module/import path.
…otcamp - Rename Terraform provider address + binary (ch8 exercise, coordinated with quiz answer + typo fix liatri.io -> liatr.io) - Rewrite site-visible devops-bootcamp.liatr.io links to engineering-bootcamp.liatr.io (quizzes, prose, selenium example) - Update Backstage catalog entity name + slug (catalog-info.yaml) - Update Docsify repo slug in index.html (drives 'Edit on GitHub' button) - Rewrite raw.githubusercontent.com/liatrio/devops-bootcamp/<sha> include URLs (6.5.4-code-coverage), verified 200 OK on new paths - Rewrite test-fixture repo-name literals + JSDoc examples (Go, jest-mock) - Fix prose oversights missed by spec 99 rename (docs/README.md docker commands, provider README, agentic-best-practices, helm NOTES) CNAME intentionally preserved: devops-bootcamp.liatr.io DNS-redirects to engineering-bootcamp.liatr.io (user-owned redirect handles third-party bookmarks). Follow-up to #827 / spec 99. Related to T4 in Spec 04.
gdsmith1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Combines the
github.com/liatrio/devops-bootcampURL sweep (originally scoped as Spec 04 / task 4.0) with the follow-up rebrand of every remainingdevops-bootcampstring a website visitor or exercise-follower would see. Two commits on the branch:chore: update repo URL references to engineering-bootcamp (#827)— Spec 04 task 4.0 scopechore: rebrand remaining devops-bootcamp references to engineering-bootcamp— follow-up sweep, previously PR chore: rebrand remaining devops-bootcamp references to engineering-bootcamp #934 (closed, cherry-picked)Commit 1 — GitHub URL sweep (closes #827)
Replaces every
github.com/liatrio/devops-bootcampreference outsidedocs/specs/**(skipped: gitignored per PR #931 / task 1.0):package.json—repository.url,bugs.url,homepageindex.html— Docsify edit URLexamples/ch8/devops-{api,resources}and 5examples/ch11/data-patterns/**/go.modfilesexamples/ch8/devops-api/go.modgains areplace github.com/liatrio/engineering-bootcamp/examples/ch7/devops-resources => ../devops-resourcesdirective — the old pinned commit hashv0.0.0-20230921193819-569bb9d9dbddfor the sibling module is not resolvable on the renamed remote; these examples run locally.examples/ch8/devops-api/go.sumregenerated viago mod tidyexamples/codeQuality/goExamples/example_test.go— test data URLs.github/prompts/new-section.prompt.mdCommit 2 — Remaining
devops-bootcampstring cleanupFollow-up sweep of everything Spec 99 / task 4.0 intentionally deferred:
index.htmlDocsifyrepo:config (drives "Edit on GitHub" corner button) +catalog-info.yamlBackstage entity name +project-slugannotation.liatr.io/terraform/devops-bootcamp→liatr.io/terraform/engineering-bootcamp; binary name + plugin-cache path inexamples/ch8/provider-setup/Makefile; matching quiz answer inchapter-8/8.1.4/provider-name-checkpoint.js. Also fixes a pre-existing typoliatri.io→liatr.ioin the same quiz file (was a typo in only the quiz; the doc always hadliatr.io).devops-bootcamp.liatr.ioURLs in quiz feedback (~20 hits across 5 quiz files), one prose link in6.5.2-functional-testing.md, andexamples/codeQuality/selenium-frame.py. Host swap only; paths + fragments preserved.raw.githubusercontent.com/liatrio/devops-bootcamp/<sha>/...include URLs in6.5.4-code-coverage.md. Verified new URLs returnHTTP 200.examples/codeQuality/goExamples/example_test.go,examples/codeQuality/jest-mock/mock.js, JSDoc ingithub.js, and the paired code fences in6.5.1-unit-testing.md. Cherry-pick merge resolved bothRepositoryandUrlfields toengineering-bootcamp(also satisfies CodeRabbit finding onexample_test.goand6.5.1-unit-testing.md).docs/README.md:1749-1750docker commands (Spec 99 renamed the same commands inCLAUDE.mdbut missed this copy),examples/ch8/devops-resources/README.md:76,docs/3-AI-Engineering/3.3.1-agentic-best-practices.md:52,examples/ch7/helm/DKS/templates/NOTES.txt:1.Why
Repo was renamed
liatrio/devops-bootcamp→liatrio/engineering-bootcamp. Goal: stop presenting the old brand internally.devops-bootcamp.liatr.ioDNS still redirects toengineering-bootcamp.liatr.ioat the Liatrio-owned DNS layer, so third-party bookmarks keep working —CNAMEis intentionally preserved.Verification
docs/specs/**grep -rE 'github\.com/liatrio/devops-bootcamp' . --exclude-dir=node_modules --exclude-dir=.git | grep -v '^\./docs/specs/'devops-apicd examples/ch8/devops-api && go build ./... && go test ./...ok devops-api 0.176sdevops-resourcescd examples/ch8/devops-resources && go build ./...npm run lintSummary: 0 issues in 0 files(173 files)npm run refresh-front-matter && git diff docs/README.mdcurl -sIon each of the 3 rewritten URLs in6.5.4-code-coverage.mdHTTP 200on all threedevops-bootcampleftgrep -rniE 'devops[- ]bootcamp' . --exclude-dir=node_modules --exclude-dir=.git | grep -v '^\./docs/specs/'Response to CodeRabbit review (PR #934, cherry-picked here)
3.3.1-agentic-best-practices.md:52— H3 heading): Skipped. The file uses**Bold Label:**uniformly for 4th-level headings inside H3 sections (~40 occurrences). Changing just line 52 would be inconsistent with the rest of the file's authoring convention. Repo-wide style-guide change is out of scope for this rename PR.6.5.1-unit-testing.md:89/117+6.5.2-functional-testing.md:56— learning-example URLs): Partially addressed. The two6.5.1-unit-testing.mdsites were fixed in the cherry-pick merge resolution (bothRepositoryandUrlnowengineering-bootcamp). The6.5.2-functional-testing.md:56site israw.githubusercontent.com/PaulDHenson/devops-bootcamp/...— that's an external contributor's fork, not a Liatrio-owned URL. Left untouched.example_test.go:10/32+devops-resources/README.md:10/20— repository slug): Addressed.example_test.goURLs fixed via merge resolution.devops-resources/README.mdlines 10 + 20 were already updated by commit 1 (task 4.0 URL sweep).Files explicitly NOT touched
CNAME— DNS handles the redirect.docs/1-introduction/1.1-devops-defined.md:17—OSU DevOps Bootcampexternal citation.docs/6-software-development-practices/6.5.2-functional-testing.md:56—PaulDHenson/devops-bootcampexternal fork URL.docs/9-kubernetes-container-orchestration/9.7.1-validating-admission-policy.md:52,9.9-controllers.md:65— captured shell prompts➜ devops-bootcamp ✗ ...(historical terminal output, not branding).docs/specs/**— gitignored after PR chore: untrack docs/specs and add to gitignore #931 merges; out of scope.Notes on scope deviations from Spec 04 task list
9.2,9.5,9.7,9.9(task plan mentioned9.6/9.8— grep is authoritative).examples/ch11/data-patterns/**/go.modfiles needed updating, missed in the original task inventory. Task 4.13's zero-match acceptance gate is the source of truth.Spec
Spec 04 —
04-spec-issues-and-deps-cleanup, task 4.0. Also finishes work deferred by Spec 99 (99-spec-bootcamp-rename).Closes #827