Repository navigation
bdns: don't strip port number in metrics - #9104
Merged
Merged
Conversation
It's no longer the case that we run Unbound listening on many ports (now we use DoH), and the port number is required to accurately identify an instance.
ezekiel
previously approved these changes
Oct 16, 2026
beautifulentropy
previously approved these changes
Oct 19, 2026
aarongable
previously approved these changes
Oct 19, 2026
jsha
dismissed stale reviews from aarongable, beautifulentropy, and ezekiel
via
October 20, 2026 19:49
fd13cad
aarongable
approved these changes
Oct 20, 2026
ezekiel
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's no longer the case that we run Unbound listening on many ports (now we use DoH), and the port number is required to accurately identify an instance.