Skip to content

Add pre-commit/prek file again, update Ruff, and fix lints - #1216

Merged
mdekstrand merged 15 commits into
lenskit:mainfrom
mdekstrand:tweak/pre-k
Sep 16, 2026
Merged

mdekstrand merged 15 commits into
lenskit:mainfrom
mdekstrand:tweak/pre-k

Conversation

@mdekstrand

@mdekstrand mdekstrand commented Sep 15, 2026

Copy link
Copy Markdown
Member

This adds pre-commit / pre-k lints again, and fixes lints with updated Ruff.

Closes #1203.

  • Add pre-commit config
  • Remove hk config
  • Auto-deactivate hk
  • Update CI checks for prek / pre-commit
  • Add prek to devcontainer

@mdekstrand mdekstrand added this to the 2026.4 milestone Sep 15, 2026
@mdekstrand mdekstrand self-assigned this Sep 15, 2026
@mdekstrand mdekstrand added build Build, test, and platform support dependencies Pull requests that update a dependency file labels Sep 15, 2026
@mdekstrand
mdekstrand marked this pull request as ready for review September 16, 2026 18:08
@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.49%. Comparing base (f871317) to head (56b701c).

Files with missing lines Patch % Lines
src/lenskit/parallel/ray.py 50.00% 1 Missing ⚠️
src/lenskit/tuning/_optuna/results.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1216   +/-   ##
=======================================
  Coverage   90.49%   90.49%           
=======================================
  Files         263      263           
  Lines       17605    17605           
=======================================
  Hits        15931    15931           
  Misses       1674     1674           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mdekstrand
mdekstrand merged commit 56b701c into lenskit:main Sep 16, 2026
43 of 44 checks passed
@mdekstrand
mdekstrand deleted the tweak/pre-k branch September 16, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Build, test, and platform support dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revert from hk to pre-commit, prek, or similar

1 participant