ci: bundle HIP runtime libraries with Windows ROCm release - #18
Merged
superm1 merged 1 commit intoOct 2, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeing the
amdhip64Windows priority based issues pop up withsdROCm/TheRock#7691.TLDR;
sdis picking up the stale driveramdhip64and crashing - copying TheRock basedamdhip64into the same directory assdresolves the issue.Adding the library bundle step that was previously added to llama.cpp CI for the same reason. This'll standardize the user experience for both apps + we have documentation reiterating this approach in the works.