Hardening and bugfixes - #434
Merged
Merged
Conversation
leducp
commented
Aug 4, 2026
Owner
- Bound every mailbox read by the buffer that carries it.
- Add a saturating conversion to the freestanding math helpers.
- Clamp DS402 setpoints to configurable integration limits.
- Saturate the simulated motor feedback.
- Fix undefined behaviour in the Timer, the ESI parser and two destructors.
leducp
force-pushed
the
fix_mailbox_length_validation
branch
from
August 4, 2026 13:51
bbedc19 to
251ac62
Compare
trns1997
approved these changes
Aug 4, 2026
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against e69a6de |
- Bound every mailbox read by the buffer that carries it.
- Move the freestanding math helpers to utils/ and add a saturating conversion.
lib/include/kickcat is on the include path, so a math.h sitting directly in it
is what every translation unit gets for #include <math.h>.
- Clamp DS402 setpoints to configurable integration limits.
- Saturate the simulated motor feedback.
- Fix undefined behaviour in the Timer, the ESI parser and two destructors.
- Add a filesystem backend to the OS layer, on top of POSIX and Win32 directly,
and move EmulatedESC, SimulatedSlave and the ESI benches onto it: no
<filesystem> nor <fstream> is left in lib/, which the embedded targets compile
too.
- Unbuffer the unit test binary's stdout and cap the ctest run: read through
ctest's pipe, a stalled or crashed run reported no output at all.
- Link libstdc++ and libgcc into the Windows unit binary: it died at load with
STATUS_ENTRYPOINT_NOT_FOUND against one of the four rival libstdc++-6.dll the
CI runners carry on PATH.
leducp
force-pushed
the
fix_mailbox_length_validation
branch
from
August 5, 2026 07:45
7b3963f to
e69a6de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.