Skip to content

Expose load_params - #96

Merged
amacati merged 3 commits into
learnsyslab:mainfrom
Yuming-Lee24:feat/export-load-params
Aug 7, 2026
Merged

Expose load_params#96
amacati merged 3 commits into
learnsyslab:mainfrom
Yuming-Lee24:feat/export-load-params

Conversation

@Yuming-Lee24

Copy link
Copy Markdown
Contributor

expose the load_params for both dynamics and control
modified the corresponding docs as well
added a unit test for dynamics param loading (for drone and controll are already covered in other tests)

@Yuming-Lee24
Yuming-Lee24 requested a review from amacati as a code owner August 7, 2026 12:51
@Yuming-Lee24
Yuming-Lee24 force-pushed the feat/export-load-params branch from 132fa50 to 262f5be Compare August 7, 2026 12:56
@Yuming-Lee24

Copy link
Copy Markdown
Contributor Author

also I have notices that:
in drone_env.py also miss using the control param loader to load params to load the thrust and does not consumed by any controller

match control_type:
        case Control.attitude:
            params = load_params(force_torque2rotor_vel, drone)
            thrust_min, thrust_max = params["thrust_min"] * 4, params["thrust_max"] * 4

modification is not included in this pr

@amacati

amacati commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Thanks! Can you change the drone_env.py as well? The code simplification would be good.

@amacati amacati left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good, just waiting for the code simplification for the env

@amacati
amacati merged commit f53a5a2 into learnsyslab:main Aug 7, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants