[tushaar-05]

Closes #15545

Summary

• Headline: Prevent an empty bottom app bar from showing up on the Facility Settings page in the app.
• Motivation: On the Facility Settings page, the save button already shows up directly inside the form when viewed in the Android app. However, the bottom bar component was still being rendered, leaving a blank 72px floating bar at the bottom of the screen that blocked content.
• Approach:
  • Moved the !isAppContext check up to <BottomAppBar> itself (similar to how DeviceSettingsPage handles it), so the bar is completely hidden in the app.
  • Updated the existing unit test in FacilityConfigPage.spec.js to confirm the bottom bar isn't rendered in app mode.

References

• Closes [UI] Empty BottomAppBar rendered on Facility Config page in app context (Android) #15545

Visual Changes (Videos / Screenshots)

Before Fix	After Fix
kolibriUI.mp4	fix.mp4

---

Reviewer guidance

• Verification performed:
  • Ran unit tests with pnpm test-jest for FacilityConfigPage.spec.js and all other facility tests (all 129 tests passed).
  • Ran linter and pre-commit checks locally with no issues.
• Reviewer testing steps:
  • In a standard browser view, confirm the "Save changes" button still appears in the bottom bar as expected.
  • In app mode (isAppContext: true), check that the empty bottom bar is gone and the save button sits inside the page form.

AI usage

I used an AI assistant to help compare the template logic with DeviceSettingsPage and adjust the corresponding test in FacilityConfigPage.spec.js. I reviewed and tested all changes locally before submitting.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

[learning-equality-bot]

👋 Hi @tushaar-05, thanks for contributing!

For the review process to begin, please verify that the following is satisfied:

• Contribution is aligned with our contributing guidelines

• Pull request description has correctly filled AI usage section & follows our AI guidance:

  AI guidance

  
  

  State explicitly whether you didn't use or used AI & how.

  If you used it, ensure that the PR is aligned with Using AI as well as our DEEP framework. DEEP asks you:

  • Disclose — Be open about when you've used AI for support.
  • Engage critically — Question what is generated. Review code for correctness and unnecessary complexity.
  • Edit — Review and refine AI output. Remove unnecessary code and verify it still works after your edits.
  • Process sharing — Explain how you used the AI so others can learn.

  
  

  Examples of good disclosures:

  "I used Claude Code to implement the component, prompting it to follow the pattern in ComponentX. I reviewed the generated code, removed unnecessary error handling, and verified the tests pass."

  "I brainstormed the approach with Gemini, then had it write failing tests for the feature. After reviewing the tests, I used Claude Code to generate the implementation. I refactored the output to reduce verbosity and ran the full test suite."

📢✨ Before we assign a reviewer:

• @rtibblesbot will pre-review this pull request. Its comments are generated by an LLM, and should be evaluated accordingly.
• We'll also invite community pre-review. See the community review guidance for both authors and reviewers.

Also check that issue requirements are satisfied & you ran pre-commit locally.

Pull requests that don't follow the guidelines will be closed.

Reviewer assignment can take up to 2 weeks.

[rtibblesbot]

🟡 Waiting for changes

Outcome: reviewed 9e0d93b

Last updated: 2026-10-28 05:31 UTC

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.20.0a2.dev1682_gabdd8ed7e.pex
Windows Installer (EXE)	kolibri-setup-0.20.0a2.dev1682+gabdd8ed7e-unsigned.exe
Debian Package	kolibri_0.20.0alpha2dev1682-0ubuntu1_all.deb
Debian Package	kolibri-server_0.20.0alpha2dev1682-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.20.0a2.dev1682+gabdd8ed7e.dmg
Android Package (APK)	kolibri-0.20.0a2.dev1682+gabdd8ed7e-debug.apk
Flatpak bundle (GNOME)	org.learningequality.Kolibri.Devel.flatpak
Raspberry Pi Image	kolibri-pi-image-0.20.0alpha2dev1682.zip
TAR file	kolibri-0.20.0a2.dev1682+gabdd8ed7e.tar.gz
WHL file	kolibri-0.20.0a2.dev1682+gabdd8ed7e-py3-none-any.whl

Smoke test screenshot

Download screenshot

[rtibblesbot]

PR #15701: no findings.

Moving v-if="!isAppContext" onto <BottomAppBar> fixes #15545. DeviceSettingsPage already hides its bar the same way.

• CI passing.
• Jest not run locally: the worktree has no node_modules.
• Manual QA did not complete, so the app-context layout is unverified in a running app.

Next step: Needs a full code review by a human engineer, then manual QA once that reviewer sets Needs QA.

• The author is outside the team: confirm this should be built at all.
• User-visible files changed: kolibri/plugins/facility/frontend/views/FacilityConfigPage/index.vue.
• In app context, confirm the facility settings page shows no empty bottom bar and Save changes still works from the page body.

---

Written by rtibblesbot, an LLM-based coding agent.

[rtibblesbot]

praise: This test now fails without the fix. The old assertion passed even with the bug's empty bar rendered.

[marcellamaki]

Code review + manual QA confirm. Thank you @tushaar-05

[rtibblesbot]

Quick check on rtibblesbot's review of this PR: react 👍 helpful · 😕 mixed · 👎 not helpful. Reply with anything specific.