Repository navigation
Distinguish unsubmitted tests in the coach learner panel and label pre-test results - #15600
Open
rtibblesbot wants to merge 4 commits into
Open
rtibblesbot wants to merge 4 commits into
rtibblesbot wants to merge 4 commits into
Conversation
Contributor
Build Artifacts
Smoke test screenshot |
rtibblesbot
marked this pull request as ready for review
October 18, 2026 05:33
Each test gains `started`: learners with a mastery log but no complete one, so the coach UI can tell "in progress" from "not started". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A started but unsubmitted test reads "The learner hasn't submitted the test yet" instead of "No progress yet". The panel's "hasn't started any units" empty state now counts started or submitted work on either test of a unit, not only the active one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The results heading now also shows for the active unit once its test closes, so pre-test results are labelled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each test's status lives in the reports, so an ended test kept showing as open until something else reloaded them. This replaces the refetch on switching to the Learning objectives tab. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rtibblesbot
force-pushed
the
issue-15593-3e41a0
branch
from
October 18, 2026 12:51
29bde38 to
994b1fb
Compare
rtibbles
reviewed
Oct 26, 2026
rtibbles
left a comment
Member
There was a problem hiding this comment.
Code changes make sense to me, and from the screenshots and screencasts, the behaviour looks broadly sensible, but I'd like QA confirmation here.
Contributor
Author
|
Holding off on changes while this PR is in Change the board status when QA is done and I'll pick up any outstanding review feedback, CI failures and conflicts on the next cycle. Written by rtibblesbot, an LLM-based coding agent. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
References
Closes #15593.
Reviewer guidance
Suggested review: Full code review, then manual QA once the reviewer sets Needs QA.
kolibri/plugins/coach/frontend/utils/index.js,kolibri/plugins/coach/frontend/views/courses/CourseSummaryPage.vue,kolibri/plugins/coach/frontend/views/courses/LearnerSidePanel.vue,kolibri/plugins/coach/frontend/views/courses/LearnerUnitReport.vue,packages/kolibri-common/strings/coursesStrings.js.unitPhasechange can replace develop's refetch on switching to the Learning Objectives tab, which the branch removes.Developer check:
unitreports/lists a learner underpre_test.startedonly until they submit; blank submits score{}.Question: should a test closed before submission read "No progress yet"?
QA steps
QA team: the coach learner panel now separates an unsubmitted test from no progress. Regressions are most probable when a test ends.
All items use Kolibri QA Channel > Courses > Hummingbird Biology. Assign it to a class with learners A and B.
Started but not submitted
Learner A shows "The learner hasn't submitted the test yet". Learner B shows "No progress yet".
Submitted with answers, and blank
Learner A shows scores. Learner B shows every objective at "0 of 1".
End tests without a reload
While a test is open, no results heading shows. After the end, "Unit 1: Anatomy & Physiology (Pre-test results)" shows, aligned with the unit title. After the post-test, it reads "(Post-test results)". In Arabic, it aligns on the right. Is the repeated title clear?
Look out for:
Evidence
Learner submits with answers, and blank
Opened but not submitted vs never opened
s1-learner-panels.webm
Ending the pre-test in place
s3-end-pretest-in-place.webm
Post-test opened, then ended
s4-end-post-test.webm
Later unit active, RTL, deep link
More captures (15)
AI usage
Used Claude Code to plan, implement and test the changes. Verified with the pytest and Jest suites for the changed files and prek.
🤖 Generated with Claude Code
Written by rtibblesbot, an LLM-based coding agent.
🟡 Held for manual QA (🧪 Needs QA)
Last updated: 2026-10-30 07:25 UTC