Repository navigation
Keep one H1 on hasVisibleHeading pages while they load - #15490
rtibblesbot wants to merge 1 commit into
Conversation
npm Package VersionsWarning The following packages have changed files but no version bump:
If these changes affect published code, consider bumping the version. |
Build Artifacts
Smoke test screenshot |
8e7e5f3 to
d4a4672
Compare
1b65fd3 to
1130012
Compare
rtibbles
left a comment
There was a problem hiding this comment.
The code looks fine from a quick read through, but please write better QA guidance, you can do better than this.
AppBarPage and ImmersivePage watch #main and show the registered title as a hidden <h1> whenever a hasVisibleHeading page has no <h1> there, so loading states keep exactly one H1. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
1130012 to
1605ba0
Compare
|
Rewrote the PR body; the old QA steps and evidence described sibling PRs' flows.
|
rtibbles
left a comment
There was a problem hiding this comment.
Code changes look good, QA confirmation needed.
|
Holding off on changes while this PR is in Change the board status when QA is done and I'll pick up any outstanding review feedback, CI failures and conflicts on the next cycle. Written by rtibblesbot, an LLM-based coding agent. |
1 similar comment
|
Holding off on changes while this PR is in Change the board status when QA is done and I'll pick up any outstanding review feedback, CI failures and conflicts on the next cycle. Written by rtibblesbot, an LLM-based coding agent. |
Summary
AppBarPageandImmersivePagerender a hidden<h1>until ahasVisibleHeadingpage's own<h1>appears in#main.References
Fixes #15467. Heading focus: #15485.
Reviewer guidance
Code review
usePageHeadingobserves#mainonly while the innermost registration setshasVisibleHeading.<h1>is excluded by template ref, so it cannot remove itself.QA steps
Setup: Chrome, a screen reader's headings list (NVDA Insert+F7, VoiceOver rotor) or the HeadingsMap extension, DevTools > Network > Slow 3G. Sign in as admin; import a channel with a course.
developEvidence
API delayed 3 s; overlay lists every
<h1>.coach-classes-reload.webm
AI usage
Claude Code wrote the change and its Jest tests.
🤖 Generated with Claude Code
Written by rtibblesbot, an LLM-based coding agent.
🟡 Held for manual QA (🧪 Needs QA)
Last updated: 2026-10-30 16:30 UTC