fix import name generation#19
Closed
mo271 wants to merge 1 commit into
Closed
Conversation
eric-wieser
reviewed
Feb 13, 2026
| let (imports, constants) := args.span (· != "--") | ||
| let imports := imports.toArray.map fun mod => { module := Syntax.decodeNameLit ("`" ++ mod) |>.get! } | ||
| let imports := imports.toArray.map fun mod => { | ||
| module := mod.splitOn "." |>.foldl Name.mkStr .anonymous |
There was a problem hiding this comment.
This looks wrong to me, dots are allowed in french quotes.
There was a problem hiding this comment.
I think String.toName is what you want instead.
|
Can you add a test? |
Author
|
closing in favour of leanprover/comparator#40 I think the code here is doing the right thing, it just could be done slighly nicer with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this potentially fixes handling of filenames starting with number, for more details see leanprover/comparator#17