Repository navigation
fix: keep findOLean's root cache valid across withImportModules - #16320
Merged
Merged
Conversation
This PR fixes a segfault when `withImportModules` is called a second time in one process and the imported module imports another package root, a regression from #15291. `findOLean` cached package roots keyed by `Name`s that may live in an imported `.olean` region, which `withImportModules` frees after use. The cache now stores `Runtime.deepCopy`s of these names. Fixes #16267 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
the
toolchain-available
Kha
marked this pull request as ready for review
November 6, 2026 18:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a segfault when
withImportModulesis called a second time in one process and the imported module imports another package root, a regression from #15291.findOLeancached package roots keyed byNames that may live in an imported.oleanregion, whichwithImportModulesfrees after use. The cache now storesRuntime.deepCopys of these names.Fixes #16267