Repository navigation
fix: cbv discharges overlap hypotheses of match equations - #16316
Open
wkrozowski wants to merge 1 commit into
Open
wkrozowski wants to merge 1 commit into
wkrozowski wants to merge 1 commit into
Conversation
wkrozowski
marked this pull request as ready for review
November 6, 2026 14:09
github-actions
Bot
added
the
toolchain-available
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves
cbvhandling of match equations. Previouslycbv, when encountering match expressions would try first to use matcher equations usingSymmachinery for theorem rewrite, with no discharger enabled, before falling back towhnf. Now, we try a discharger that can deal with overlap hypotheses, by applyingcbvto each of the arguments of the overlaph hypothesis. Literals nested inside constructor pattterns, still fall back towhnf, sinceSym.simphas no simproc for constructor injectivity yet.Partially solves #16313.