Repository navigation
Conversation
RIvance
force-pushed
the
patch-highlighting
branch
2 times, most recently
from
May 13, 2026 15:01
ad0d817 to
a7710f4
Compare
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
RIvance
marked this pull request as ready for review
May 13, 2026 17:52
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves semantic highlighting (addresses #2305) by reusing information already present in the
InfoTreeand elaboration context.This PR DOES NOT:
InfoTreestructure.It also DOES NOT require any change in lean4-vscode extension because the server still emits standard semantic token types from the existing
SemanticTokenType.No new token kinds are introduced, so existing VS Code themes should continue to work.
The mapping is:
Type,Sortclass(A : Type)and uses ofAtypeParameterinterfacestructP : Prop,P : A → PropenumT : Type,F : A → TypetypetypeenumenumMemberpropertyfunction(x : Nat)parametervariableThe PR also handles declaration names and self-references while the declaration is still being elaborated, including recursive function calls and inductive self-references in constructor types.
Closes #2305
LHS: With Semantic Highlighting; RHS: Without Semantic Highlighting