Skip to content

chore: don't coverage check truly unnecessary stuff #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robsimmons merged 1 commit into from
Nov 1, 2026
Merged

chore: don't coverage check truly unnecessary stuff #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions shared/shared.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { describe, expect, it, test } from 'vitest'

import { bwrapProjectDir, describeValue, leanVersionCompare, toolchainHasModules } from './shared.ts'
import { describeValue, leanVersionCompare, toolchainHasModules } from './shared.ts'

describe('leanVersionCompare', () => {
it('should throw on non-lean version numbers', () => {
Expand Down Expand Up @@ -37,10 +37,6 @@ test('toolchainHasModules', () => {
expect(toolchainHasModules('leanprover/lean4-nightly:nightly-2027-01-01')).toBe(true)
})

test('bwrapProjectDir', () => {
expect(bwrapProjectDir('abc')).toBe('/workspace/abc/')
})

test('describeValue', () => {
expect(describeValue(null)).toBe('null')
expect(describeValue({})).toBe('object')
Expand Down
6 changes: 3 additions & 3 deletions shared/shared.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,8 @@ export const COLLAB_SOCKET_FILENAME = 'collab.sock'
/**
* Where bwrap mounts the given project directory.
*/
export function bwrapProjectDir(projectName: string) {
return `/workspace/${projectName}/`
}
/* v8 ignore next */
export const bwrapProjectDir = (projectName: string) => `/workspace/${projectName}/`

/** Path to workspace metadata file in VSCode bwraps. */
export const BWRAP_METADATA_PATH = '/workspace/.lean-workbench.json'
Expand All @@ -161,6 +160,7 @@ export const adminEmail = 'admin@admin.localhost'
export const MIN_ADMIN_PASSWORD_LENGTH = 8

/** Pseudo-email for dev user number `n`. */
/* v8 ignore next */
export const devModeEmail = (n: number) => `dev${String(n)}@dev.localhost`

/**
Expand Down
Loading