Repository navigation
chore: vitest testing in the shared workspace - #205
Merged
Merged
Conversation
robsimmons
force-pushed
the
vitest-intro
branch
from
October 30, 2026 12:24
d735ea1 to
ec41310
Compare
robsimmons
force-pushed
the
vitest-intro
branch
from
October 30, 2026 12:31
ec41310 to
b5ea767
Compare
jcreedcmu
approved these changes
Oct 30, 2026
Vtec234
approved these changes
Oct 30, 2026
Comment on lines
+40
to
+42
| test('bwrapProjectDir', () => { | ||
| expect(bwrapProjectDir('abc')).toBe('/workspace/abc/') | ||
| }) |
Member
There was a problem hiding this comment.
Suggested change
| test('bwrapProjectDir', () => { | |
| expect(bwrapProjectDir('abc')).toBe('/workspace/abc/') | |
| }) |
Maybe this is test bloat?
Collaborator
Author
There was a problem hiding this comment.
More like coverage checking extremism. Switched to v8-ignoring it, which is a more correct move (most correct move is probably not to care so much about coverage but I was close 😄 )
Co-authored-by: Wojciech Nawrocki <13901751+Vtec234@users.noreply.github.com>
robsimmons
added a commit
that referenced
this pull request
Nov 1, 2026
I meant to merge this as part of #205 but messed up my commit stack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.