Skip to content

feat: Update later credits and fancy updates soundness proofs #411

Merged
lzy0505 merged 9 commits into
leanprover-community:masterfrom
lzy0505:zliu/fix-stale-6ee29e
May 26, 2026
Merged

feat: Update later credits and fancy updates soundness proofs #411
lzy0505 merged 9 commits into
leanprover-community:masterfrom
lzy0505:zliu/fix-stale-6ee29e

Conversation

@lzy0505

@lzy0505 lzy0505 commented May 25, 2026

Copy link
Copy Markdown
Collaborator

Description

Fixes #396, following the recent MR in Rocq: https://gitlab.mpi-sws.org/iris/iris/-/merge_requests/1217.

Checklist

  • My code follows the mathlib naming and code style conventions
  • I have updated PORTING.md as appropriate
  • I have added my name to the authors section of any appropriate files

Generative AI Guidelines

AI assistance is permitted when making contributions to Iris-Lean, however, generative AI systems tend to produce code which takes a long time to review.
Please carefully review your code to ensure it meets the following standards.

  • Your PR should avoid duplicating constructions found in Iris-Lean or in the Lean standard library.
  • have statements that do not aid readability or code reuse should be inlined.
  • Your proofs should be shortened such that their overall structure is explicable to a human reader. As a goal, aim to express one idea per line.
  • In general, proofs should not perform substantially more case splitting than their Rocq counterparts.

In our experience, a good place to begin refactoring is by re-arranging and combining independent tactic invocations.
We also find that pointing generative AI systems to the Mathlib code style guidelines can help them perform some of this refactoring work.

@lzy0505 lzy0505 requested a review from Kaptch May 25, 2026 20:49
@Kaptch

Kaptch commented May 26, 2026

Copy link
Copy Markdown
Collaborator

Thank you for the PR! I'll take a look in a moment

@Kaptch

Kaptch commented May 26, 2026

Copy link
Copy Markdown
Collaborator

Nicely done! I added only minor fixes (mostly leftover isplit; iassumption in LaterCredits before we had iframe).
I think we can merge any time, but probably let's wait for Michael's comment about Hint Immediate.

While there shouldn't be problem anywhere with Plain->Persistent (at least, I don't remember any place, where it might be required, apart from soundness), it would be nice to know if there is a fix for it.

Comment thread Iris/Iris/BI/Plainly.lean Outdated
@markusdemedeiros

Copy link
Copy Markdown
Collaborator

Just briefly skimmed it, and it looks great :)

Comment thread Iris/Iris/Instances/Lib/LaterCredits.lean Outdated
@lzy0505

lzy0505 commented May 26, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks! Merging.

@lzy0505 lzy0505 merged commit 8559d19 into leanprover-community:master May 26, 2026
5 checks passed
@lzy0505 lzy0505 deleted the zliu/fix-stale-6ee29e branch May 26, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stale porting entries against Iris Rocq master

4 participants