refactor(testing): collapse the two placeholder-proof branches#1160
Merged
tcoratger merged 1 commit intoJun 18, 2026
Merged
Conversation
The empty-bit-override and invalid-signature cases built the same zeroed placeholder proof and differed only in the participant bitfield. Merge them, selecting participants with an explicit is-not-None check. Emitted vectors are byte-identical. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
GossipAttestationSpec.build_signed, the empty-bit-override branch and the invalid-signature branch built the same zeroed-32-byte placeholder proof and differed only in the participant bitfield. Merged them into one branch, selecting participants with an explicitis not Nonecheck (notor, to avoid the falsy-AggregationBitstrap).The Path 0–3 comment block is preserved. Pure structural refactor — the emitted (participants, proof) pair is identical for each original input. Found in the packages/testing audit (TYPES-03).
Lint:
ruff check+ruff formatclean.